Improve logging for locked file acquisition #6777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| err | ||
| ); | ||
| } else { | ||
| debug!("Released lock at `{}`", self.0.path().display()); |
There was a problem hiding this comment.
Should this be trace! like the above?
There was a problem hiding this comment.
Maybe since it comes after all the other output.
| ) | ||
| })?; | ||
|
|
||
| debug!("Acquired lock for `{resource}`"); |
There was a problem hiding this comment.
Should this be trace! like the above?
There was a problem hiding this comment.
I don't think so — the acquired lock message above is debug level. The trace logs are for the acquire lock error message and the check message.
There was a problem hiding this comment.
It still feels like a lot for --verbose IMO.
There was a problem hiding this comment.
That's fine with me I think, but we'll want to change both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistency etc. when debugging a deadlock