fix: replace std::fs::canonicalize with Simplified::simple_canonicaliz… #6776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue on Windows where
std::fs::canonicalize
can fail or panic when resolving paths on mapped network drives. By replacing it withSimplified::simple_canonicalize
, we aim to improve the robustness and cross-platform compatibility of path resolution.Changes
CANONICAL_CWD
inpath.rs
to useSimplified::simple_canonicalize
instead ofstd::fs::canonicalize
.Why
std::fs::canonicalize
has known issues with resolving paths on mapped network drives on Windows, which can lead to panics or incorrect path resolution.Simplified::simple_canonicalize
internally usesdunce::canonicalize
, which handles these cases more gracefully, ensuring better stability and reliability.Test Plan
Since
simple_canonicalize
has already been tested in a prior PR, this change is expected to work without introducing any new issues. No additional tests are necessary beyond ensuring existing tests pass, which will confirm the correctness of the change.