Use generic pubgrub incompatibility reason #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3335 will not alter performanceComparing Summary
|
zanieb
reviewed
May 2, 2024
zanieb
reviewed
May 2, 2024
zanieb
reviewed
May 2, 2024
konstin
force-pushed
the
konsti/pubgrub-generic-incompatibility
branch
2 times, most recently
from
a64cfed to
0b93a71
Compare
|
The whole plural handling imho makes a lot of effort over just reformulating plural-independent |
konstin
commented
May 3, 2024
konstin
force-pushed
the
konsti/pubgrub-generic-incompatibility
branch
from
6f1e47d to
a56a2d4
Compare
konstin
commented
May 7, 2024
| ╰─▶ Because black==23.10.1 was not found in the cache and you require black==23.10.1, we can conclude that the requirements are unsatisfiable. | ||
| ╰─▶ Because black was not found in the cache and you require black==23.10.1, we can conclude that the requirements are unsatisfiable. |
There was a problem hiding this comment.
The message improves here because it's the versions of black, not that specific version, that is missing in the cache
zanieb
reviewed
May 7, 2024
| ╰─▶ Because example-a-961b4c22==1.0.0 was not found in the package registry and you require example-a-961b4c22==1.0.0, we can conclude that the requirements are unsatisfiable. | ||
| ╰─▶ Because example-a-961b4c22 was not found in the package registry and you require example-a-961b4c22==1.0.0, we can conclude that the requirements are unsatisfiable. |
There was a problem hiding this comment.
I'm confused why does this test error? Shouldn't this resolve cc @charliermarsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pubgrub got a new feature where all unavailability is a custom, instead of the reasonless
UnavailableDependenciesand our customStringtype previously (pubgrub-rs/pubgrub#208). This PR introduces aUnavailableReasonthat tracks either an entire version being unusable, or a specific version. The error messages now also track this difference properly.The pubgrub commit is our main rebased onto the merged pubgrub-rs/pubgrub#208, i'll push
konsti/main-rebase-generic-reasontomainafter checking for rebase problems.