Improve error message for -r *.lock inputs #16282
Open
+89
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still some tests to fix. I am on it |
|
All checks passed, i’m still learning the codebase, so please let me know if anything isn’t quite right. I’ll gladly make any corrections. Sincerely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Detect and reject uv lockfiles (*.lock) early when passed via -r, showing a clear error instead of a parse failure. Fixes #16192. It was made using 4.5 Sonnet and Perplexity. There are probably some fixes to do. I am here to (try) fix !
Test Plan
Ran cargo test -p uv --test it_install_from_uv_lockfile . I confirm the new error message is emitted as expected.