Use a global flags instance for wheel check #16047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
internal
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
|
I'm on the fence. I'm wary because it introduces a second path for configuration which I think could be confusing. It also adds a footgun to our Rust APIs, but I think it's okay not to prioritize those. |
|
I'm also on the fence, but it seems like a strict improvement over #16046 and I worry that the alternative (of threading the flag through all those places) will be a net negative for maintainability. |
charliermarsh
force-pushed
the
charlie/legacy
branch
from
5c51f92 to
0666562
Compare
zanieb
approved these changes
Sep 29, 2025
charliermarsh
force-pushed
the
charlie/legacy
branch
from
0666562 to
b625338
Compare
charliermarsh
force-pushed
the
charlie/flags
branch
from
3b6131d to
61c4d67
Compare
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
charliermarsh
force-pushed
the
charlie/flags
branch
from
61c4d67 to
cece3ce
Compare
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This stands up the idea proposed in https://github.com/astral-sh/uv/pull/16046/files#r2384395797.