Add --all-groups to uv pip install and uv pip sync
#14789
+222
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/all-groups
branch
2 times, most recently
from
ecd66d4 to
a5b3839
Compare
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
charliermarsh
force-pushed
the
charlie/all-groups
branch
from
a5b3839 to
4526e58
Compare
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
charliermarsh
added
enhancement
zanieb
reviewed
Jul 22, 2025
Comment on lines
+1862
to
+1863
| #[arg(long, overrides_with("all_groups"), hide = true)] | ||
| pub no_all_groups: bool, |
There was a problem hiding this comment.
Interesting, we don't have this anywhere else right now.
zanieb
reviewed
Jul 22, 2025
Comment on lines
+9760
to
+9761
| .arg("-r").arg("pyproject.toml") | ||
| .arg("--all-groups"), @r" |
There was a problem hiding this comment.
This seems misleading, the -r shouldn't be needed there, right?
zanieb
reviewed
Jul 22, 2025
Comment on lines
+11609
to
+11611
| .arg("-r") | ||
| .arg("pylock.toml") | ||
| .arg("--all-groups"), @r" |
There was a problem hiding this comment.
Gosh, I was not aware we added -r pylock.toml --group support. That's sort of concerning, since it doesn't match the existing --group semantics (i.e., not applying to other input files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--all-groupsdoesn't accept a path; instead, it assumes thepyproject.tomlin the root.Closes #14483.