-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add new uv-keyring
crate that vendors the keyring-rs
crate
#14725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jtfmumm
wants to merge
7
commits into
main
Choose a base branch
from
jtfm/vendor-keyring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtfmumm
commented
Jul 18, 2025
@@ -0,0 +1,306 @@ | |||
// use common::{generate_random_string, init_logger}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to determine if we still want these threading tests. They were created for the sync version of these functions in the original crate.
c362c0f
to
f824432
Compare
f824432
to
dd52955
Compare
dd52955
to
cd35a4e
Compare
6f13007
to
077a583
Compare
077a583
to
0150bf9
Compare
e023955
to
d1ca7d6
Compare
d1ca7d6
to
8b2dd13
Compare
8b2dd13
to
56ea26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Includes:
keyring-rs
crate into newuv-keyring
workspace cratesecret-service
crate that does not require clients on Linux to havelibdbus
on their machineskeyring-rs
PRTODO: