Skip to content

Add new uv-keyring crate that vendors the keyring-rs crate #14725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jtfmumm
Copy link
Contributor

@jtfmumm jtfmumm commented Jul 18, 2025

Work in progress

Includes:

  • Vendoring keyring-rs crate into new uv-keyring workspace crate
  • Moving to the async secret-service crate that does not require clients on Linux to have libdbus on their machines
  • Removing iOS code paths
  • Patching in @oconnor663 's changes from his keyring-rs PR

TODO:

  • Add keyring tests to CI
  • Determine if we still want the threading tests (currently commented out)
  • Document unsafe code
  • Improve PR description

@jtfmumm jtfmumm added the internal A refactor or improvement that is not user-facing label Jul 18, 2025
@@ -0,0 +1,306 @@
// use common::{generate_random_string, init_logger};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to determine if we still want these threading tests. They were created for the sync version of these functions in the original crate.

@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 18, 2025 13:58 — with GitHub Actions Inactive
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from c362c0f to f824432 Compare July 18, 2025 13:59
@jtfmumm jtfmumm had a problem deploying to uv-test-registries July 18, 2025 14:03 — with GitHub Actions Error
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from f824432 to dd52955 Compare July 18, 2025 14:03
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 18, 2025 14:06 — with GitHub Actions Inactive
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from dd52955 to cd35a4e Compare July 21, 2025 12:18
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 21, 2025 12:21 — with GitHub Actions Inactive
@jtfmumm jtfmumm temporarily deployed to uv-test-publish July 21, 2025 12:21 — with GitHub Actions Inactive
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 21, 2025 12:36 — with GitHub Actions Inactive
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from 6f13007 to 077a583 Compare July 21, 2025 12:39
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 21, 2025 12:42 — with GitHub Actions Inactive
@jtfmumm jtfmumm temporarily deployed to uv-test-publish July 21, 2025 12:43 — with GitHub Actions Inactive
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from 077a583 to 0150bf9 Compare July 21, 2025 13:12
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 21, 2025 13:16 — with GitHub Actions Inactive
@jtfmumm jtfmumm temporarily deployed to uv-test-publish July 21, 2025 13:16 — with GitHub Actions Inactive
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from e023955 to d1ca7d6 Compare July 21, 2025 13:28
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 21, 2025 13:31 — with GitHub Actions Inactive
@jtfmumm jtfmumm temporarily deployed to uv-test-publish July 21, 2025 13:42 — with GitHub Actions Inactive
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from d1ca7d6 to 8b2dd13 Compare July 24, 2025 14:18
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 24, 2025 14:21 — with GitHub Actions Inactive
@jtfmumm jtfmumm temporarily deployed to uv-test-publish July 24, 2025 14:21 — with GitHub Actions Inactive
@jtfmumm jtfmumm force-pushed the jtfm/vendor-keyring branch from 8b2dd13 to 56ea26a Compare July 24, 2025 14:30
@jtfmumm jtfmumm temporarily deployed to uv-test-registries July 24, 2025 14:32 — with GitHub Actions Inactive
@jtfmumm jtfmumm temporarily deployed to uv-test-publish July 24, 2025 14:32 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant