[ty] Have SemanticIndex::place_table() and SemanticIndex::use_def_map return references
#19944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
ty
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
AlexWaygood
force-pushed
the
alex/refactor-use-def
branch
from
7234453 to
2b24d92
Compare
AlexWaygood
changed the base branch from
main
to
alex/namedtuple-multiple-inheritance
…map` return references
AlexWaygood
force-pushed
the
alex/refactor-use-def
branch
from
2b24d92 to
adaabb7
Compare
AlexWaygood
changed the base branch from
alex/namedtuple-multiple-inheritance
to
main
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fact that these return owned
Arcs has already caused a number of borrow-checker issues that have been annoying to workaround. And I just ran into this yet again while working on another change.Everything seems to compile if we return
&Arcfrom these methods rather thanArc, and (since the implicit lifetime of the borrow is'db) this solves a lot of borrow-checker issues!Test Plan
Existing tests