-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[red-knot] Protocols, but the only protocols in the world are the ones in the typing
module
#17625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupportsIndex
and Sized
SupportsIndex
and Sized
|
SupportsIndex
and Sized
typing
module
e6b7163
to
492ceea
Compare
typing
moduletyping
module
245af44
to
694d823
Compare
… to `NominalInstanceType`
694d823
to
bde0eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a somewhat silly version of #17614 where we pretend that the only protocols in the world are the ones that are defined in the typing module. I'm not intending for this to be merged; I'm mainly interested in seeing if this has any impact on mypy_primer or not.
Test Plan
cargo test -p red_knot_python_semantic