Skip to content

Conversation

@jjhelmus
Copy link
Contributor

closes #737

@jjhelmus jjhelmus added the platform:darwin Specific to the macOS platform label Oct 28, 2025
@zanieb zanieb requested a review from geofft October 28, 2025 21:42
Copy link
Collaborator

@geofft geofft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual diff is fine for me, anything worth testing here? I'll let you merge if you're confident in the testing or that we don't need it :)

@jjhelmus
Copy link
Contributor Author

This does not change the resulting artifact so I'm not seeing anything worthwhile to test.

The existing behavior was excluding the flags passed via EXTRA_TARGET_LDFLAGS when linking libtk but these flags are also included in CFLAGS which are correctly passed.

I checked the logs of this build against those prior to this change and with the changes the flags in questions (e.g. -arch arm64 -mmacosx-version-min=11.0 -isysroot ...) are duplicated with this change.

@jjhelmus jjhelmus merged commit c7bf8b1 into astral-sh:main Oct 29, 2025
610 of 611 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform:darwin Specific to the macOS platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build-tk.sh drops EXTRA_TARGET_LDFLAGS for macos

2 participants