Fix musl detection in Python 3.12 and below #827
Merged
+91
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofft
added
platform:linux
CPython 3.10 and below don't even attempt to fix the target triple for musl. CPython 3.11 and 3.12 do, but in our setup it doens't work right because of an autoconf bug. CPython 3.13 rewrites the target triple detection logic and works fine. Meanwhile, the previous patch to this part of configure.ac is no longer relevant because clang stopped implementing --print-multiarch in LLVM 16 (llvm/llvm-project@e05edb19), so we can drop those patches. Fixes #724.
geofft
force-pushed
the
geofft/fix-musl-triple
branch
from
2db5c1d to
e4ebdca
Compare
zanieb
reviewed
Oct 26, 2025
cpython-unix/build-cpython.sh
Outdated
Comment on lines
118
to
121
| # CPython <=3.10 doesn't properly detect musl. CPython <=3.12 tries, but fails in our environment | ||
| # because of an autoconf bug. CPython >=3.13 is fine. | ||
| # Backport the musl detection code from CPython 3.13 so it loads | ||
| # extension modules with the right suffix. |
There was a problem hiding this comment.
Nit: This mixed line length wrapping is perturbing
There was a problem hiding this comment.
I meant to remove those last two lines because we're not backporting the code, not sure how I left them in.... will fix when I figure out the build failure
zanieb
approved these changes
Oct 26, 2025
This was referenced Oct 27, 2025
We're still on Clang 14 for musl builds (#829).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPython 3.10 and below don't even attempt to fix the target triple for musl. CPython 3.11 and 3.12 do, but in our setup it doens't work right because of an autoconf bug. CPython 3.13 rewrites the target triple detection logic and works fine.
Fixes #724.