Skip to content

Fix NativeAOT runs to include db machines. #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LoopedBard3
Copy link
Contributor

Fix NativeAOT runs to include db machines.

This was inadvertently incorrectly set in the initial PR switching to the new test addition flow: #2099.

@LoopedBard3 LoopedBard3 self-assigned this Jul 16, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the NativeAOT benchmark configuration to properly include database machines in the CI runs. The main issue was that the NativeAOT test type was incorrectly set to 2 instead of 3, which excluded database configurations from the benchmark runs.

  • Changes NativeAOT test type from 2 to 3 in the benchmark configuration
  • Adds database profile arguments to NativeAOT benchmark jobs
  • Reorganizes job dependencies and display names to maintain proper CI flow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
build/benchmarks_ci.json Updates NativeAOT type from 2 to 3 to include database machines
build/benchmarks-ci-01.yml Adds database profile arguments to NativeAOT jobs and reorganizes job structure
build/benchmarks-ci-02.yml Updates job dependencies and reorganizes framework job placement

Copy link
Contributor

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 requested a review from sebastienros July 16, 2025 22:00
@LoopedBard3 LoopedBard3 merged commit 4f899da into aspnet:main Jul 16, 2025
2 checks passed
@LoopedBard3 LoopedBard3 deleted the FixIncorrectNativeAOTBenchmarksCISettings branch July 16, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants