feat: support both icon and image rendering for competitive sites #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the CompetitiveSites component to support both icon-based and image-based rendering within the profile link. - Added conditional logic to render either an icon (via iconifyClassname) or an image (via imageSrc). - Ensured styling is applied consistently via logo.style. - Maintained existing anchor tag structure with target and rel attributes for safe external linking. This improves flexibility by allowing platforms without iconify support to use custom images.
There was a problem hiding this comment.
Pull Request Overview
This PR adds flexibility to the CompetitiveSites component by supporting both icon-based and image-based rendering for competitive site platforms. This allows platforms without iconify support to use custom images instead.
Key changes:
- Added conditional rendering logic to support both iconify icons and custom images
- Maintained consistent styling and safe external linking attributes
- Preserved existing component structure while extending functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@16ratneshkumar Thank you for contributing. @all-contributors please add @16ratneshkumar for code |
|
I've put up a pull request to add @16ratneshkumar! 🎉 |
This was referenced Oct 5, 2025
ashutosh1919
pushed a commit
that referenced
this pull request
Oct 6, 2025
…petitive sites section (#413) * Update instructions for changing icons and using custom images in competitive sites section - Updated the README to provide clearer guidance on how to change icons in the Basic Qualification and Certifications section using Simple Icons. - Added step-by-step instructions for replacing icons via `iconifyClassname`. - Included instructions for using custom images via the `imageSrc` attribute, including details about file placement and styling. - Clarified the precedence of `imageSrc` over `iconifyClassname` when both are present. - This improves developer experience by making customization more intuitive. See PR #410 for related changes. * docs:Change grammatical mistakes in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the CompetitiveSites component to support both icon-based and image-based rendering within the profile link.
This improves flexibility by allowing platforms without iconify support to use custom images.