chore(docs): Remove gettext references from Enum docs #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chazwatkins
force-pushed
the
improvement/2172
branch
3 times, most recently
from
cbe3bb3 to
60e7fc1
Compare
zachdaniel
reviewed
Jul 24, 2025
chazwatkins
force-pushed
the
improvement/2172
branch
from
60e7fc1 to
11be02a
Compare
chazwatkins
changed the title
gettext references from Ash.Type.Enum docs
chazwatkins
force-pushed
the
improvement/2172
branch
from
11be02a to
f0a4a84
Compare
chazwatkins
changed the title
gettext references from Ash.Type.Enum docs
|
Ok, this one is good to go. |
|
@chazwatkins Sorry to be an ass but now that I see what you mean about this just being a new callback that anyone could define, since we don't actually use it...you were right 😢 Sorry for the whiplash, but your plan of just removing gettext from the docs is the right way. |
No worries, man. Don't take it as you being an ass at all. This one didn't take long anyway. |
chazwatkins
force-pushed
the
improvement/2172
branch
from
f0a4a84 to
958bd79
Compare
chazwatkins
changed the title
zachdaniel
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
gettextfromAsh.Type.Enumdoc examples to avoid confusion that using functions on the values forlabelanddescriptionwill occur at runtime.closes #2172
Contributor checklist
Leave anything that you believe does not apply unchecked.