Skip to content

fix: install should report missing plugins #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

andrecloutier
Copy link
Contributor

@andrecloutier andrecloutier commented Feb 16, 2025

Summary

Indicates in the "install" output if a requested tool/version could not be installed due to the plugin not being installed. This will cause the application to exit with a non-zero exit code. Prior to this change, install would complete successfully without any indication that some required tool(s) were not successfully configured.

Other Information

Sample output:

andre@Andres-MacBook-Pro asdf % ./asdf install
version {version 1.8.2} of bats is already installed
version {version 1.18.2-otp-27} of elixir is already installed
version {version 27.2.2} of erlang is already installed
version {version 1.23.4} of golang is already installed
version {version 8.12.1} of gradle is already installed
version {version zulu-21.40.17} of java is already installed
version {version 3.6.0} of shfmt is already installed
missing plugin for shellcheck
andre@Andres-MacBook-Pro asdf % echo $?
1

@andrecloutier
Copy link
Contributor Author

Closed this PR in favour of: #1970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant