feat: bn254 maptocurve #972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows bn254 to support hashing to curve. the RFC does not have test vectors for bn254, so the tests are somewhat impoverished, but the functionality does work.
emberian
requested review from
z-tech,
mmagician and
weikengchen
and removed request for
a team
|
@Pratyush can you help me move this forward? I see @burdges and @mmagician in previous PR for elligator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
allows bn254 to support hashing to curve.
the RFC does not have test vectors for bn254,
so the tests are somewhat impoverished, but
the functionality does work according to tests.
closes: #855
some progress towards #815, however the present implementation does not support "all" curves. I am not sure the trait setup is amenable to that. this PR makes it easy to extend support to any particular curve, however. I do not think this closes that issue.