Feat(eos_designs, eos_cli_config_gen): Added the support to enable or disable bgp peer validation in vrf #6071
+747
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disable bgp peer validation in vrf
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6071
# Activate the virtual environment
source test-avd-pr-6071/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@bgp-peer-validation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,bgp-peer-validation --force
# Optional: Install AVD examples
cd test-avd-pr-6071
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
gmuloc
reviewed
Oct 29, 2025
| mlag_peer=self.shared_utils.mlag_peer, | ||
| interface=interface_name, | ||
| peer_interface=interface_name, | ||
| if isinstance(bgp_vrf, EosCliConfigGen.RouterBgp.VrfsItem): |
There was a problem hiding this comment.
I guess you are doing this for type checking - lets do this in another PR (and think if can find a better way as this looks like a lot of code suddenly)
There was a problem hiding this comment.
The other way i can see is using the obtain method which dont require much if else for type check also not much complex.
There was a problem hiding this comment.
you dont' need obtain cf suggestions
|
gmuloc
reviewed
Oct 30, 2025
Comment on lines
+328
to
+340
| bgp_vrf.neighbor_interfaces.append_new( | ||
| name=interface_name, | ||
| peer_group=self.shared_utils.mlag_vrfs_peer_group_name, | ||
| remote_as=self.shared_utils.formatted_bgp_as, | ||
| description=AvdStringFormatter().format( | ||
| self.inputs.mlag_bgp_peer_description, | ||
| mlag_peer=self.shared_utils.mlag_peer, | ||
| interface=interface_name, | ||
| peer_interface=interface_name, | ||
| ) | ||
| or None, | ||
| ) | ||
| bgp_vrf.neighbor_interfaces.obtain(interface_name).metadata.validate_state = vrf.validate_bgp_peers |
There was a problem hiding this comment.
Suggested change
| bgp_vrf.neighbor_interfaces.obtain(interface_name).metadata.validate_state = vrf.validate_bgp_peers | |
| neighbor_interface = bgp_vrf.neighbor_interfaces.append_new( | |
| name=interface_name, | |
| peer_group=self.shared_utils.mlag_vrfs_peer_group_name, | |
| remote_as=self.shared_utils.formatted_bgp_as, | |
| description=AvdStringFormatter().format( | |
| self.inputs.mlag_bgp_peer_description, | |
| mlag_peer=self.shared_utils.mlag_peer, | |
| interface=interface_name, | |
| peer_interface=interface_name, | |
| ) | |
| or None, | |
| ) | |
| neighbor_interface.metadata.validate_state = vrf.validate_bgp_peers |
There was a problem hiding this comment.
the diff is messed up but you get the gist (thanks Github UI...)
gmuloc
requested changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added the support to enable or disable bgp peer validation in vrf
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Introduce a knob to enable or disable BGP peer state validation on a per-VRF basis.
eos_designs Additions:
eos_cli_config_gen Additions:
How to test
Run molecule
Checklist
User Checklist
Repository Checklist