-
Couldn't load subscription status.
- Fork 257
Feat(eos_designs): Move wan_use_agent_env_var_for_kernel_software_forwarding_ecmp to platform setting #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Feat(eos_designs): Move wan_use_agent_env_var_for_kernel_software_forwarding_ecmp to platform setting #6061
Conversation
…warding_ecmp to platform setting
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6061
# Activate the virtual environment
source test-avd-pr-6061/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@kernel_sw_forwarding#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,kernel_sw_forwarding --force
# Optional: Install AVD examples
cd test-avd-pr-6061
ansible-playbook arista.avd.install_examples |
994f157 to
9d43c04
Compare
for more information, see https://pre-commit.ci
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
| - wan_use_agent_env_var_for_kernel_software_forwarding_ecmp: true | ||
| + platform_settings: | ||
| + - platforms: [vEOS-LAB] | ||
| + kernel_ecmp_cli: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be false to retain existing config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the old key had default false and the new key has default true , rest behavior is same (true for true)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make clear that vEOS-LAB is the platform for node in consideration. The current inputs do not give information about the platform of the node.



Change Summary
Move wan_use_agent_env_var_for_kernel_software_forwarding_ecmp to platform setting
Related Issue(s)
Fixes #6037
Component(s) name
arista.avd.eos_designsProposed changes
Move wan_use_agent_env_var_for_kernel_software_forwarding_ecmp to platform setting
How to test
Molecule tests
Checklist
User Checklist
Repository Checklist