Skip to content

Conversation

@Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Oct 27, 2025

Change Summary

Move wan_use_agent_env_var_for_kernel_software_forwarding_ecmp to platform setting

Related Issue(s)

Fixes #6037

Component(s) name

arista.avd.eos_designs

Proposed changes

Move wan_use_agent_env_var_for_kernel_software_forwarding_ecmp to platform setting

How to test

Molecule tests

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6061
# Activate the virtual environment
source test-avd-pr-6061/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@kernel_sw_forwarding#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,kernel_sw_forwarding --force
# Optional: Install AVD examples
cd test-avd-pr-6061
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 27, 2025
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 27, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 28, 2025
@sonarqubecloud
Copy link

- wan_use_agent_env_var_for_kernel_software_forwarding_ecmp: true
+ platform_settings:
+ - platforms: [vEOS-LAB]
+ kernel_ecmp_cli: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be false to retain existing config?

Copy link
Contributor Author

@Shivani-gslab Shivani-gslab Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old key had default false and the new key has default true , rest behavior is same (true for true)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make clear that vEOS-LAB is the platform for node in consideration. The current inputs do not give information about the platform of the node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Move wan_use_agent_env_var_for_kernel_software_forwarding_ecmp to platform setting

2 participants