Feat(anta_runner): Add VerifyOSPFMaxLSA, VerifyOSPFNeighborState ospf tests #6057
+1,760
−969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6057
# Activate the virtual environment
source test-avd-pr-6057/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/vitthalmagadum/avd.git@anta_runner/ospf#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/vitthalmagadum/avd.git#/ansible_collections/arista/avd/,anta_runner/ospf --force
# Optional: Install AVD examples
cd test-avd-pr-6057
ansible-playbook arista.avd.install_examples |
MaheshGSLAB
reviewed
Oct 27, 2025
| @@ -0,0 +1,10 @@ | |||
| # Custom router ospf structured_config to test | |||
| custom_structured_configuration_router_ospf: | |||
There was a problem hiding this comment.
This works but if possible if we can add proper underlay config with ospf routing between two devices would be good to have it. You can take the example molecule for the inputs.
There was a problem hiding this comment.
Updated underlay_routing_protocol as ospf for DC2.
Thanks!!
| | [**VerifyMlagInterfaces**](https://anta.arista.com/stable/api/tests/mlag/#anta.tests.mlag.VerifyMlagInterfaces){:target="_blank"} | Verifies there are no inactive or active-partial MLAG ports. | `mlag_configuration` | | ||
| | [**VerifyMlagStatus**](https://anta.arista.com/stable/api/tests/mlag/#anta.tests.mlag.VerifyMlagStatus){:target="_blank"} | Verifies the global MLAG state is 'active' and other parameters are consistent. | `mlag_configuration` | | ||
| | [**VerifyNTP**](https://anta.arista.com/stable/api/tests/system/#anta.tests.system.VerifyNTP){:target="_blank"} | Verifies that the device's NTP service is synchronized with a time source. | *None* | | ||
| | [**VerifyOSPFMaxLSA**](https://anta.arista.com/stable/api/tests/routing.ospf/#anta.tests.routing.ospf.VerifyOSPFMaxLSA){:target="_blank"} | Verifies all OSPF instances did not cross the maximum LSA threshold. | *None* | |
There was a problem hiding this comment.
Suggested change
| | [**VerifyOSPFMaxLSA**](https://anta.arista.com/stable/api/tests/routing.ospf/#anta.tests.routing.ospf.VerifyOSPFMaxLSA){:target="_blank"} | Verifies all OSPF instances did not cross the maximum LSA threshold. | *None* | | |
| | [**VerifyOSPFMaxLSA**](https://anta.arista.com/stable/api/tests/routing.ospf/#anta.tests.routing.ospf.VerifyOSPFMaxLSA){:target="_blank"} | Verifies that all OSPF instances did not cross the maximum LSA threshold. | `router_ospf` | |
There was a problem hiding this comment.
Updated. Thanks!!
| | [**VerifyMlagStatus**](https://anta.arista.com/stable/api/tests/mlag/#anta.tests.mlag.VerifyMlagStatus){:target="_blank"} | Verifies the global MLAG state is 'active' and other parameters are consistent. | `mlag_configuration` | | ||
| | [**VerifyNTP**](https://anta.arista.com/stable/api/tests/system/#anta.tests.system.VerifyNTP){:target="_blank"} | Verifies that the device's NTP service is synchronized with a time source. | *None* | | ||
| | [**VerifyOSPFMaxLSA**](https://anta.arista.com/stable/api/tests/routing.ospf/#anta.tests.routing.ospf.VerifyOSPFMaxLSA){:target="_blank"} | Verifies all OSPF instances did not cross the maximum LSA threshold. | *None* | | ||
| | [**VerifyOSPFNeighborState**](https://anta.arista.com/stable/api/tests/routing.ospf/#anta.tests.routing.ospf.VerifyOSPFNeighborState){:target="_blank"} | Verifies all OSPF neighbors are in FULL state. | *Checks all neighbors to be in `Full` state, `2Ways` is not accepted. `VerifyOSPFSpecificNeighbors` can be used in a user-defined catalog instead for the device with a neighbor that is expected to be in `2Ways`.* | |
There was a problem hiding this comment.
Suggested change
| | [**VerifyOSPFNeighborState**](https://anta.arista.com/stable/api/tests/routing.ospf/#anta.tests.routing.ospf.VerifyOSPFNeighborState){:target="_blank"} | Verifies all OSPF neighbors are in FULL state. | *Checks all neighbors to be in `Full` state, `2Ways` is not accepted. `VerifyOSPFSpecificNeighbors` can be used in a user-defined catalog instead for the device with a neighbor that is expected to be in `2Ways`.* | | |
| | [**VerifyOSPFNeighborState**](https://anta.arista.com/stable/api/tests/routing.ospf/#anta.tests.routing.ospf.VerifyOSPFNeighborState){:target="_blank"} | Verifies that all OSPF neighbors are in the *full* state; the *2Ways* state is **not** accepted. Use `VerifyOSPFSpecificNeighbors` in a user-defined catalog instead for any device with a neighbor that is expected to be in the *2Ways* state. | `router_ospf` | |
There was a problem hiding this comment.
Updated. Thanks!!
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added VerifyOSPFMaxLSA, VerifyOSPFNeighborState ospf tests
Related Issue(s)
Fixes #5757
Component(s) name
arista.avd.anta_runnerProposed changes
Added VerifyOSPFMaxLSA, VerifyOSPFNeighborState ospf tests
How to test
Run molecule
Checklist
User Checklist
Repository Checklist