Feat(eos_cli_config_gen): Add packet type match criteria support in traffic_policies #6050
Conversation
github-actions
bot
added
role: eos_cli_config_gen
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6050
# Activate the virtual environment
source test-avd-pr-6050/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@traffic_policies_packet_type#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,traffic_policies_packet_type --force
# Optional: Install AVD examples
cd test-avd-pr-6050
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
changed the title
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/traffic_policies.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Outdated
Show resolved
Hide resolved
…olicies.j2 Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
There was a problem hiding this comment.
let's take a step back and agree on a data model.
As you can see from the issue there is also a multicast option on some platforms (we need to find one)
packet type
vxlan decap [ exclude ]
multicast
Any reason to not keep a packet_type top level?
https://www.arista.com/en/support/toi/eos-4-24-2f/14550-support-for-traffic-policy-on-interfaces
Added multicast |
| keys: | ||
| vxlan: | ||
| type: str | ||
| valid_values: ["decap", "decap exclude"] |
There was a problem hiding this comment.
both can be configured at the same time so this schema won't work right?
There was a problem hiding this comment.
I checked on EOS-4.35.0F-44178984.4350F node we can not configure both.
| {# -- Packet Type #} | ||
| {% set row.packet_type = [] %} | ||
| {% if match.packet_type.vxlan is arista.avd.defined %} | ||
| {% do row.packet_type.append(match.packet_type.vxlan) %} |
There was a problem hiding this comment.
we need to keep something about VXLAN or it is not understandbale
|
4 participants
Change Summary
Add packet type match criteria support in traffic_policies
Related Issue(s)
Fixes #6047
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Added new data model
How to test
CI
Checklist
Repository Checklist