-
Couldn't load subscription status.
- Fork 257
Test: Make molecule ansible native #6022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Test: Make molecule ansible native #6022
Conversation
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6022
# Activate the virtual environment
source test-avd-pr-6022/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/joelbreton2/avd.git@Test--make-molecule-ansible-native#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/joelbreton2/avd.git#/ansible_collections/arista/avd/,Test--make-molecule-ansible-native --force
# Optional: Install AVD examples
cd test-avd-pr-6022
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so these may be dumb questions, but:
1/ this looks like what I would have expected
2/ don't you need to add more stuff in my crappy empty default/molecule.yml? (maybe not :p )
3/ I am not sure where we rely on default and where not :)
4/ if some test_sequence don't make sense, don't hesitate to adjust them
Would be good to have some rationalization between all our examples :) some of them are (pre-)historical 🦣
ansible_collections/arista/avd/extensions/molecule/ansible_only/molecule.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/example-single-dc-l3ls/molecule.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/ansible_only/molecule.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/cv_deploy/molecule.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/eos_designs-l2ls/molecule.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/molecule.yml
Outdated
Show resolved
Hide resolved
| backend: ansible-playbook | ||
| args: | ||
| ansible_playbook: | ||
| - --inventory=inventory/hosts.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same maybe lets take the oppotrunity to rename the files the same in every scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the filename in the path, do you want me to renamed all inventory files to hosts.yml for the inventory.yml remaining?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets align everything for our sanity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All inventory files are now hosts.yml
ansible_collections/arista/avd/extensions/molecule/example-campus-fabric/molecule.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/example-cv-pathfinder/molecule.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/example-isis-ldp-ipvpn/converge.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/extensions/molecule/example-isis-ldp-ipvpn/molecule.yml
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as said in one comment let's use the same name for all inventory names
|



Change Summary
Change molecule testing structure to follow ansible-native configuration
Source
Related Issue(s)
Addresses part of #5990 - the second part (ansible-native)
Proposed changes
How to test
Local: run
molecule test --scenario-name <scenario-name>i.e.
molecule test --scenario-name example-single-dc-l3lsCI: Verify test results
Checklist
User Checklist
eos_cli_config_gen_deprecated_varsis still requireddestroyvscleanupsequenceRepository Checklist