Feat(anta_runner): Vxlan1 being down is failing VerifyInterfacesStatus when no tenants are defined #6005

vitthalmagadum · 2025-10-13T10:19:02Z

Change Summary

Vxlan1 being down is failing VerifyInterfacesStatus when no tenants are defined

Related Issue(s)

Fixes #5880

Component(s) name

arista.avd.anta_runner

Proposed changes

Vxlan1 being down is failing VerifyInterfacesStatus when no tenants are defined

How to test

run molecule

Checklist

User Checklist

N/A

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

…s when no tenants are defined

github-actions · 2025-10-13T10:19:13Z

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6005
# Activate the virtual environment
source test-avd-pr-6005/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/vitthalmagadum/avd.git@anta_runner/vxlan#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/vitthalmagadum/avd.git#/ansible_collections/arista/avd/,anta_runner/vxlan --force
# Optional: Install AVD examples
cd test-avd-pr-6005
ansible-playbook arista.avd.install_examples

python-avd/pyavd/_anta/input_factories/interfaces.py

python-avd/pyavd/_anta/models.py

python-avd/pyavd/_anta/logs.py

github-actions · 2025-10-15T14:25:50Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-10-15T14:25:51Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-10-16T06:18:31Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

python-avd/pyavd/_anta/input_factories/interfaces.py

python-avd/pyavd/_anta/models.py

python-avd/pyavd/_anta/input_factories/interfaces.py

...sta/avd/extensions/molecule/anta_runner/anta/avd_catalogs/allow_bgp_vrfs_run/dc1-spine1.json

python-avd/pyavd/_anta/input_factories/interfaces.py

python-avd/pyavd/_anta/models.py

MaheshGSLAB

LGTM, just update the host vars custom structure config comment more descriptive about what we are testing so in future we dont need to look what is the test for.

github-actions · 2025-10-29T08:25:13Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-10-29T12:11:36Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2025-10-29T15:56:40Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-10-29T16:07:11Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

carl-baillargeon · 2025-10-29T18:10:07Z

python-avd/pyavd/_anta/input_factories/interfaces.py

        if self.device.is_vtep:
-            interfaces.append(InterfaceState(name="Vxlan1", status="up"))
+            if self.structured_config.vxlan_interface.vxlan1.vxlan.shutdown:
+                interfaces.append(InterfaceState(name="Vxlan1", status="down"))


Suggested change

interfaces.append(InterfaceState(name="Vxlan1", status="down"))

interfaces.append(InterfaceState(name="Vxlan1", status="adminDown"))

Updated. Thanks!!

carl-baillargeon · 2025-10-29T18:18:28Z

python-avd/pyavd/_anta/input_factories/interfaces.py

+                self.logger_adapter.debug(
+                    LogMessage.SOURCE_INTERFACE_SHUTDOWN, interface="Vxlan1", source_interface=self.device.vxlan_source_interface_status.name
+                )
+            elif not self.structured_config.vxlan_interface.vxlan1.vxlan.vlans and not self.structured_config.vxlan_interface.vxlan1.vxlan.vrfs:


We also need to check for vlan_range.

Updated the check. Thanks!!

carl-baillargeon · 2025-10-29T18:33:50Z

python-avd/pyavd/_anta/input_factories/interfaces.py

+                    LogMessage.SOURCE_INTERFACE_SHUTDOWN, interface="Vxlan1", source_interface=self.device.vxlan_source_interface_status.name
+                )
+            elif not self.structured_config.vxlan_interface.vxlan1.vxlan.vlans and not self.structured_config.vxlan_interface.vxlan1.vxlan.vrfs:
+                self.logger_adapter.debug(LogMessage.VNI_NOT_CONFIGURED, interface="Vxlan1")


See if you can use the existing LogMessage.INPUT_MISSING_FIELDS.

We might lose the original message here.

carl-baillargeon · 2025-10-29T19:27:08Z

python-avd/pyavd/_anta/input_factories/interfaces.py

-            interfaces.append(InterfaceState(name="Vxlan1", status="up"))
+            if self.structured_config.vxlan_interface.vxlan1.vxlan.shutdown:
+                interfaces.append(InterfaceState(name="Vxlan1", status="down"))
+            elif self.device.vxlan_source_interface_status and self.device.vxlan_source_interface_status.shutdown:


Since we don't need this in other tests, let's just use a small helper function in AntaTestInputFactory to check if the Loopback (or DPS) interface is not shutdown. The helper could return a bool.

The VXLAN interface will also be down if an IP address is not configured on the source interface so we need to check if the Loopback (or DPS) has ip_address configured or ipv6_address if the VXLAN encapsulation is IPv6 (vxlan_interface.vxlan1.vxlan.encapsulations.ipv6).

Updated this checks inside helper. Thanks!!

sonarqubecloud · 2025-10-30T05:43:34Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Feat(anta_runner): Vxlan1 being down is failing VerifyInterfacesStatu…

a466231

…s when no tenants are defined

vitthalmagadum requested review from a team as code owners October 13, 2025 10:19

vitthalmagadum marked this pull request as draft October 13, 2025 10:19

github-actions bot assigned vitthalmagadum Oct 13, 2025

github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 13, 2025

fixing pre-commit failure

774e72b

vitthalmagadum force-pushed the anta_runner/vxlan branch from d3ae7a1 to 774e72b Compare October 13, 2025 10:31

vitthalmagadum requested a review from MaheshGSLAB October 13, 2025 10:32

MaheshGSLAB reviewed Oct 15, 2025

View reviewed changes

python-avd/pyavd/_anta/input_factories/interfaces.py Outdated Show resolved Hide resolved

MaheshGSLAB reviewed Oct 15, 2025

View reviewed changes

python-avd/pyavd/_anta/input_factories/interfaces.py Outdated Show resolved Hide resolved

MaheshGSLAB reviewed Oct 15, 2025

View reviewed changes

python-avd/pyavd/_anta/models.py Outdated Show resolved Hide resolved

MaheshGSLAB reviewed Oct 15, 2025

View reviewed changes

python-avd/pyavd/_anta/models.py Outdated Show resolved Hide resolved

laxmikantchintakindi reviewed Oct 15, 2025

View reviewed changes

python-avd/pyavd/_anta/logs.py Outdated Show resolved Hide resolved

github-actions bot added the state: conflict PR with conflict label Oct 15, 2025

Merge branch 'devel' into anta_runner/vxlan

1a2fd77

github-actions bot removed the state: conflict PR with conflict label Oct 16, 2025

vitthalmagadum and others added 2 commits October 17, 2025 07:59

Merge branch 'devel' into anta_runner/vxlan

530b326

addressed review comments: updated the input factories

03a310d

vitthalmagadum force-pushed the anta_runner/vxlan branch from fdbd3c0 to 03a310d Compare October 17, 2025 04:55

vitthalmagadum and others added 4 commits October 17, 2025 07:50

addressed review comments: updated unit tests

0a8796e

Merge branch 'devel' into anta_runner/vxlan

ba49a71

Merge branch 'devel' into anta_runner/vxlan

1478f78

fixing the pre-commit failures

b381c5c

vitthalmagadum requested review from MaheshGSLAB and laxmikantchintakindi October 20, 2025 03:39

MaheshGSLAB reviewed Oct 23, 2025

View reviewed changes

python-avd/pyavd/_anta/input_factories/interfaces.py Outdated Show resolved Hide resolved

python-avd/pyavd/_anta/models.py Outdated Show resolved Hide resolved

python-avd/pyavd/_anta/models.py Outdated Show resolved Hide resolved

MaheshGSLAB reviewed Oct 24, 2025

View reviewed changes

python-avd/pyavd/_anta/models.py Outdated Show resolved Hide resolved

python-avd/pyavd/_anta/input_factories/interfaces.py Outdated Show resolved Hide resolved

...sta/avd/extensions/molecule/anta_runner/anta/avd_catalogs/allow_bgp_vrfs_run/dc1-spine1.json Outdated Show resolved Hide resolved

vitthalmagadum and others added 2 commits October 24, 2025 14:05

Merge branch 'devel' into anta_runner/vxlan

dd2d6ff

addressed review comments: updated the models.py

fa24846

MaheshGSLAB reviewed Oct 24, 2025

View reviewed changes

python-avd/pyavd/_anta/input_factories/interfaces.py Outdated Show resolved Hide resolved

updated docstring

ca384ca

vitthalmagadum requested a review from MaheshGSLAB October 24, 2025 11:07

MaheshGSLAB reviewed Oct 27, 2025

View reviewed changes

python-avd/pyavd/_anta/models.py Outdated Show resolved Hide resolved

vitthalmagadum and others added 3 commits October 27, 2025 13:03

Merge branch 'devel' into anta_runner/vxlan

f8294be

updated the code covergae

cd3d6e4

ignoring pyrigh warning

884be89

vitthalmagadum requested a review from MaheshGSLAB October 27, 2025 09:11

vitthalmagadum and others added 2 commits October 27, 2025 21:17

Merge branch 'devel' into anta_runner/vxlan

a4f146e

removed unnecessary data class

0bea7ad

MaheshGSLAB marked this pull request as ready for review October 28, 2025 04:41

MaheshGSLAB approved these changes Oct 28, 2025

View reviewed changes

github-actions bot added the state: conflict PR with conflict label Oct 29, 2025

removed pyright ignores

386545a

github-actions bot removed the state: conflict PR with conflict label Oct 29, 2025

Merge branch 'devel' into anta_runner/vxlan

4d42eee

github-actions bot added the state: conflict PR with conflict label Oct 29, 2025

Merge branch 'devel' into anta_runner/vxlan

7e0310a

github-actions bot removed the state: conflict PR with conflict label Oct 29, 2025

carl-baillargeon requested changes Oct 29, 2025

View reviewed changes

addressed review comments: updated the moldels.py util to InputFactory

9d6537e

	interfaces.append(InterfaceState(name="Vxlan1", status="down"))
	interfaces.append(InterfaceState(name="Vxlan1", status="adminDown"))

Uh oh!

Feat(anta_runner): Vxlan1 being down is failing VerifyInterfacesStatus when no tenants are defined #6005

Are you sure you want to change the base?

Feat(anta_runner): Vxlan1 being down is failing VerifyInterfacesStatus when no tenants are defined #6005

Conversation

vitthalmagadum commented Oct 13, 2025

Change Summary

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaheshGSLAB left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 30, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants