Skip to content

Conversation

@gtkacz
Copy link
Contributor

@gtkacz gtkacz commented Sep 28, 2025

Description

Alter ISO parsing methods to accept str subclasses. Closes #260.

Checklist

  • Build runs successfully
  • Type stubs updated
  • Docs updated
  • If docstrings were affected, check if they appear correctly in the docs as well as autocomplete

Release checklist (maintainers only)

  • Version updated in pyproject.toml
  • Version updated in src/whenever/__init__.py
  • Version updated in changelog
  • Branch merged
  • Tag created and pushed
  • Confirm publish job runs successfully
  • Github release created

@ariebovenberg
Copy link
Owner

Thanks for the PR! Looks good at first glance. I'll probably relax subclass restrictions across the board for int/str/float before the next release

@ariebovenberg ariebovenberg changed the base branch from main to next-release September 29, 2025 06:14
@ariebovenberg ariebovenberg merged commit d5876d6 into ariebovenberg:next-release Sep 29, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

np.str_ raises TypeError: Argument must be a string

2 participants