Skip to content

Conversation

saforem2
Copy link
Member

@saforem2 saforem2 commented Oct 8, 2025

Description

Fix code background color in dark theme to match background

Screenshots

Before Screen Shot 2025-10-07 at 22 25 18
After Screen Shot 2025-10-07 at 22 25 19

Related Issue(s)

Type of Change

  • Documentation content update (new page, formatting/typo changes, adding more info, etc.)
  • Functionality bug fix
  • New feature (mkdocs feature, mkdocs-material style changes, HTML/CSS/JS customization, developer or repo tool)

Checklist

  • I have run make serve or make build-docs locally and verified that my changes render correctly
  • I have added at least one Label to this PR

Copilot Summary

This pull request makes minor adjustments to the alcf-extra.css stylesheet, primarily refining the appearance of inline code blocks and navigation headers.

Styling updates:

  • Updated the background and text color for inline code blocks within .md-typeset, improving contrast and readability. The old rule was commented out and replaced with a new one.
  • Adjusted the padding for navigation header list items from 9px to 8px for a slightly more compact layout.

Other:

  • Removed an unnecessary blank line for minor code cleanliness.

@saforem2 saforem2 requested a review from felker as a code owner October 8, 2025 03:27
@saforem2 saforem2 requested review from Copilot and removed request for felker October 8, 2025 03:27
@saforem2 saforem2 added the style subjective design choices, language conventions, how and when to use mkdocs & theme features label Oct 8, 2025
@saforem2 saforem2 requested a review from felker October 8, 2025 03:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the code block background color in dark theme to improve visual contrast and readability. The changes update the CSS styling rules to ensure inline code blocks have appropriate colors that match the dark theme background.

  • Updated inline code block styling to use darker background with lighter text in dark theme
  • Made minor padding adjustment to navigation header list items for better spacing
  • Removed unnecessary blank line for code cleanliness

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@saforem2
Copy link
Member Author

saforem2 commented Oct 9, 2025

@sbx-bnagle I fixed the code background in this if you want to see how it looks

@sbx-bnagle
Copy link
Contributor

@saforem2 Looks good!

@saforem2 saforem2 requested a review from atanikan October 10, 2025 11:59
Copy link
Member

@atanikan atanikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atanikan atanikan merged commit 8943567 into main Oct 10, 2025
1 check passed
@atanikan atanikan deleted the saforem2/dark-code-fix branch October 10, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style subjective design choices, language conventions, how and when to use mkdocs & theme features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants