Skip to content

Add git precommit hook and github actions #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 21, 2025
Merged

Add git precommit hook and github actions #67

merged 13 commits into from
May 21, 2025

Conversation

chen-argmax
Copy link
Collaborator

@chen-argmax chen-argmax commented May 21, 2025

Description

  • Add github action check-format and build-test-kotlin to run spotless, detekt and android unit tests on PRs
  • Update spotless to use clang-format 14 - it has a stable version on both mac and ubuntu, making it possible to work on local and remote env. Also apply the fix on newly added c files
  • Update a git precommit hook to apply spotless formatter for 3 sets of files: kt, gradle and cpp, if no files were changed after reformatting abort the commit
  • update readme to configure precommit hook and clang-format

Type of Change

  • Bug fix 🐛
  • New feature 🚀
  • Refactor 🔄
  • Documentation update 📖
  • Other (please describe)

Test Plan

  • I have run bash test/test_build_all.sh and it ran successfully
  • I have tested this change on all relevant platforms.

Checklist

  • My code follows the project's style guidelines.
  • I have updated relevant documentation (if applicable).
  • I have added appropriate tests (if applicable).
  • I have self-reviewed my code before requesting review.

@chen-argmax chen-argmax requested a review from ZachNagengast May 21, 2025 22:54
@chen-argmax chen-argmax marked this pull request as ready for review May 21, 2025 23:04
@ZachNagengast ZachNagengast self-requested a review May 21, 2025 23:56
@chen-argmax chen-argmax merged commit bfce0d5 into main May 21, 2025
2 checks passed
@chen-argmax chen-argmax deleted the chen/ci branch May 21, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants