Skip to content

Fix typo in suppressTokens variable name across multiple files #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

r0227n
Copy link

@r0227n r0227n commented Apr 24, 2025

This pull request fixes a typo in the suppressTokens property across multiple files in the WhisperKit codebase. The property was previously misspelled as supressTokens. The changes ensure consistency in naming and improve code readability.

Typo Fixes in suppressTokens Property:

  • Corrected the spelling of supressTokens to suppressTokens in the documentation comments of the WhisperKitConfig class. (Sources/WhisperKit/Core/Configurations.swift)
  • Updated the DecodingOptions struct to use the corrected suppressTokens property in its definition, initializer, and default assignment logic. (Sources/WhisperKit/Core/Configurations.swift) [1] [2] [3]
  • Fixed the usage of supressTokens to suppressTokens in the TextDecoder class, ensuring compatibility with the updated DecodingOptions struct. (Sources/WhisperKit/Core/TextDecoder.swift)
  • Updated the CLIArguments struct in the CLI module to reflect the corrected spelling in its property definition and help description. (Sources/WhisperKitCLI/CLIArguments.swift)
  • Adjusted the TranscribeCLI struct to use the corrected suppressTokens property when mapping CLI arguments to decoding options. (Sources/WhisperKitCLI/TranscribeCLI.swift)[Copilot is generating a summary...]

@ZachNagengast
Copy link
Contributor

There is currently already a PR for this #296. Unfortunately, this is a breaking change and would require us to deprecate the old spelling before fully switching over to retain backwards compatibility for the existing implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants