Skip to content

Fix sd3 layer norm bug #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 27, 2024
Merged

Fix sd3 layer norm bug #25

merged 4 commits into from
Aug 27, 2024

Conversation

arda-argmax
Copy link
Collaborator

No description provided.

@arda-argmax arda-argmax requested a review from atiorh August 27, 2024 07:10
atiorh
atiorh requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@atiorh atiorh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work when norm_module is None. Perhaps leverage nn.Identity in that case?

@arda-argmax arda-argmax linked an issue Aug 27, 2024 that may be closed by this pull request
Python example code issue #24
Closed
@arda-argmax arda-argmax mentioned this pull request Aug 27, 2024
Closed
@atiorh atiorh merged commit d915340 into main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiorh atiorh atiorh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python example code issue
2 participants
@arda-argmax @atiorh