Use task to install Python package dependencies in website deployment workflows #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some GitHub Actions workflows must install the appropriate version of Go and Python. Previously the version was configured in the workflow, and so the template installation documentation included instructions for setting the project's version of the framework in the workflow. A new approach is now used to get Go and Python versioning information from a single source in the configuration file, so there is no longer any version configuration in the workflow, rendering those instructions obsolete. The instructions were not removed at the time the workflows were migrated to the new system.
… workflows The "Task" task runner is used to perform common development and maintenance operations in Arduino tooling projects. One such operation is the installation of Python package dependencies using Poetry. The project website deployment workflows rely on Python packages, and so contain a step to install them. Previously, this was done by invoking the Poetry command directly from the workflow. That is problematic because it means multiple copies of the command must be maintained, and the maintainer might easily overlook the need to do so for these workflows since we expect there to be only one instance of the command. The workflows are hereby changed to use the standardized approach to installing Python package dependencies.
per1234
added
type: imperfection
per1234
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Task task runner tool is used to perform common development and maintenance operations in Arduino tooling projects.
One such operation is the installation of Python package dependencies using Poetry. The project website deployment workflows rely on Python packages, and so contain a step to install them. Previously, this was done by invoking the Poetry command directly from the workflow. That is problematic because it means multiple copies of the command must be maintained, and the maintainer might easily overlook the need to do so for these workflows since we expect there to be only one instance of the command.
The workflows are hereby changed to use the standardized approach to installing Python package dependencies.