Skip to content

Fixed compiler-cache on Windows when there are non-ASCII characters in file path #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2024

Fixed panic in convertAnsiBytesToString implementation

91c7fb3
Select commit
Loading
Failed to load commit list.
Merged

Fixed compiler-cache on Windows when there are non-ASCII characters in file path #2733

Fixed panic in convertAnsiBytesToString implementation
91c7fb3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 16, 2024 in 1s

67.67% (target 30.00%)

View this Pull Request on Codecov

67.67% (target 30.00%)

Details

Codecov Report

Attention: Patch coverage is 58.82353% with 28 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (ea09108) to head (91c7fb3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/arduino/builder/internal/utils/utils.go 67.30% 14 Missing and 3 partials ⚠️
...nal/arduino/builder/internal/utils/ansi_windows.go 35.71% 6 Missing and 3 partials ⚠️
...rnal/arduino/builder/internal/utils/ansi_others.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2733      +/-   ##
==========================================
- Coverage   67.68%   67.67%   -0.02%     
==========================================
  Files         234      236       +2     
  Lines       22285    22327      +42     
==========================================
+ Hits        15083    15109      +26     
- Misses       6017     6030      +13     
- Partials     1185     1188       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov