Skip to content

Fixed locales (translations) not being detected with default config #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2024

Give LANG env var priority (windows)

01e72e3
Select commit
Loading
Failed to load commit list.
Merged

Fixed locales (translations) not being detected with default config #2724

Give LANG env var priority (windows)
01e72e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2024 in 1s

67.55% (target 30.00%)

View this Pull Request on Codecov

67.55% (target 30.00%)

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (7ee4cf7) to head (01e72e3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
commands/instances.go 0.00% 2 Missing and 1 partial ⚠️
internal/i18n/detect_windows.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2724      +/-   ##
==========================================
- Coverage   67.62%   67.55%   -0.07%     
==========================================
  Files         237      237              
  Lines       22354    22356       +2     
==========================================
- Hits        15116    15103      -13     
- Misses       6048     6063      +15     
  Partials     1190     1190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.