-
-
Notifications
You must be signed in to change notification settings - Fork 283
Fix arduino101load argument passing if binary path contains spaces #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@calvinatintel @bigdinotech @eriknyquist , please review the change. @noelpaz @russmcinnis , please perform verification testing. Will merge the change to main trunk upon completion. Targeted for Deneb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fine solution, but I think {build.path}
should be provided with the spaces escaped from the upstream.
http://forum.arduino.cc/index.php?topic=448542.0 shows the same problem indeed |
@russmcinnis @noelpaz Please test |
@russmcinnis @noelpaz Is this tested? |
I tested this by saving the skecth in a folder with spaces in the name pleace note than when I named my Sketch "S P A C E D Blink", it renamed it into S_P_A_C_E_S__Blink and the IDE spit out this messgae: The sketch name had to be modified. Sketch names can only consist @calvinatintel explained that it is to verify that the enclosing folders that will have spaces. Fix is verified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix verified
@facchinm -- fix verified. @yashaswini-hanji -- Please Squash and Merge |
PR merged |
This issue was first reported to the support channel and was solved by the proposed patch