Jira 795 Make read / write calls to be blocking, git issue #383 #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add the parameter of read to support block/unblock call.
2. Changed file list
libraries/CurieBLE/src/BLECharacteristic.cpp
libraries/CurieBLE/src/BLECharacteristic.h
libraries/CurieBLE/src/internal/BLECallbacks.cpp
libraries/CurieBLE/src/internal/BLECharacteristicImp.cpp
libraries/CurieBLE/src/internal/BLECharacteristicImp.h
|
Originally all calls were designed to be blocking by default, can this PR be updated to reflect this? |
|
Please note that this PR is going to be closed and is replaced by, |
|
This PR is replaced by PR 418. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libraries/CurieBLE/src/BLECharacteristic.cpp
libraries/CurieBLE/src/BLECharacteristic.h
libraries/CurieBLE/src/internal/BLECallbacks.cpp
libraries/CurieBLE/src/internal/BLECharacteristicImp.cpp
libraries/CurieBLE/src/internal/BLECharacteristicImp.h
Fix #383