-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat[mermaid]:integration of mermaid #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat[mermaid]:integration of mermaid #1732
Conversation
@asminkarki012 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1732 +/- ##
==========================================
+ Coverage 28.35% 28.88% +0.53%
==========================================
Files 85 89 +4
Lines 5273 5449 +176
==========================================
+ Hits 1495 1574 +79
- Misses 3778 3875 +97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- frontend/package.json: Language not supported
Comments suppressed due to low confidence (2)
frontend/src/components/MermaidRenderer.tsx:35
- [nitpick] Consider using a more robust unique ID generation method (e.g., a UUID library) to minimize potential collisions if multiple diagrams are rendered in quick succession.
const id = `mermaid-${Math.random().toString(36).substring(2, 9)}`;
frontend/src/components/MermaidRenderer.tsx:225
- [nitpick] Although using the array index as a key is common for static lists, consider using a unique identifier for each download option in case the list order changes in the future.
<li key={index}>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Charlesnorris509 |
@asminkarki012 On the mermaidRendering.tsx file, you could use Lazy rendering to minimize the number of ressources needed to process the components of the files it basically divide the code, stores the files on intermediate storage, and only reprocess the files when it's changed. Here's a file that goes in depth on that process |
thank you for clarifying, |
55502b3
to
545353d
Compare
feature
🚀 Feature: mermaid.js.org in conversation rendering #1634