chore: pass schemas to opa test #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
|
This PR will be ready for review when we remove Trivy from the dependencies. |
|
interesting, what does passing the schema to the tests do differently? Is it able to type check? |
|
Yes, passing the schema to the tests performs type checking. This works the same way as it does now inside Trivy by passing the schema in compile checks. Right now the schema is checked by Trivy itself in some Go tests. But in the future, when we remove Trivy from dependencies, we will need to pass the schema to OPA for type checking. |
|
It may be better to pass the schema to |
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
simar7
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.