Skip to content

fix: set restrictive permissions (0600) on gRPC Unix socket #4983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

fix: set restrictive permissions (0600) on gRPC Unix socket #4983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/server/grpc/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import (
"context"
"net"
"os"
"time"

"google.golang.org/grpc"
Expand Down Expand Up @@ -36,6 +37,17 @@
logger.Errorw("Failed to start GRPC server", "protocol", s.protocol, "address", s.listenAddr, "error", err)
return
}

// Set restrictive permissions on Unix socket
if s.protocol == "unix" {
err = os.Chmod(s.listenAddr, 0600)
if err != nil {
logger.Errorw("Failed to set permissions on Unix socket. This may leave the socket with insecure permissions and allow unauthorized access.", "path", s.listenAddr, "error", err)
_ = lis.Close()
return
}

Check warning on line 48 in pkg/server/grpc/server.go

View check run for this annotation

Codecov / codecov/patch

pkg/server/grpc/server.go#L45-L48 

Added lines #L45 - L48 were not covered by tests
}

s.listener = lis

srvCtx, srvCancel := context.WithCancel(ctx)
Expand Down