Skip to content

chore: update txn build opt for compatible with older aptos node #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Haupc
Copy link

@Haupc Haupc commented Jun 20, 2025

Description

Aptos now support NoAccountSignature in simulation for fee payer and multi agent transaction. But it's only supported on node version >= 1.19.1. I add an old way to simulate using public key of fee payer to construct authenticator with zero signature. It would support more wide range of aptos node versions.

Related Links

@Haupc Haupc requested review from gregnazario and a team as code owners June 20, 2025 17:38
@gregnazario
Copy link
Contributor

Description

Aptos now support NoAccountSignature in simulation for fee payer and multi agent transaction. But it's only supported on node version >= 1.19.1. I add an old way to simulate using public key of fee payer to construct authenticator with zero signature. It would support more wide range of aptos node versions.

Related Links

Interesting... is anyone running a node version < 1.19.1?

Aptos is on 1.30... something right now

@Haupc
Copy link
Author

Haupc commented Jun 21, 2025

Description

Aptos now support NoAccountSignature in simulation for fee payer and multi agent transaction. But it's only supported on node version >= 1.19.1. I add an old way to simulate using public key of fee payer to construct authenticator with zero signature. It would support more wide range of aptos node versions.

Related Links

Interesting... is anyone running a node version < 1.19.1?

Aptos is on 1.30... something right now

I'm not sure about is is anyone running a node version < 1.19.1 now.

But I think that backward compatibility isn't just for current users - it's for attracting new developers who are building on forks or derivative projects. Supporting them grows our ecosystem and brings in more contributors who might otherwise choose a different foundation. I can see the movement chain is using a quite low version of aptos. In the future it could be more and more chains like that. We keep the sdk compatible with all of them will make Aptos move ecosystem strong and engage more builders

@Haupc
Copy link
Author

Haupc commented Jun 24, 2025

@gregnazario please take a look

@gregnazario
Copy link
Contributor

Description

Aptos now support NoAccountSignature in simulation for fee payer and multi agent transaction. But it's only supported on node version >= 1.19.1. I add an old way to simulate using public key of fee payer to construct authenticator with zero signature. It would support more wide range of aptos node versions.

Related Links

Interesting... is anyone running a node version < 1.19.1?
Aptos is on 1.30... something right now

I'm not sure about is is anyone running a node version < 1.19.1 now.

But I think that backward compatibility isn't just for current users - it's for attracting new developers who are building on forks or derivative projects. Supporting them grows our ecosystem and brings in more contributors who might otherwise choose a different foundation. I can see the movement chain is using a quite low version of aptos. In the future it could be more and more chains like that. We keep the sdk compatible with all of them will make Aptos move ecosystem strong and engage more builders

Unfortunately, we don't support derivatives. Not using a public key is much more adaptable. Derivatives are welcome to build their own SDK forks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants