add digital asset client with create_collection and mint capabilities #170

Tlazypanda · 2025-06-06T06:46:25Z

Description

Add digital asset client with create_collection and mint capabilities. Also added an examples file to test out the flow.

Test Plan

Test file is yet to be added. + Functionality like transfer & indexing is remaining

Related Links

gregnazario

Would be good to add unit tests on some of the functions.

Additionally, run gofumpt -l -w . to format and golangci-lint run to lint.

It's looking pretty good though

gregnazario · 2025-06-08T20:56:24Z

digital_asset_client.go

+// SerializeString serializes a single string using the BCS format
+func SerializeString(input string) ([]byte, error) {
+	return bcs.SerializeSingle(func(ser *bcs.Serializer) {
+		ser.WriteString(input)
+	})
+}


We should add this to bcs if it isn't there already

gregnazario · 2025-06-09T02:47:38Z

digital_asset_client.go

+// === COLLECTION OPERATIONS ===
+
+// CreateCollection creates a new collection using the Digital Asset standard
+func (dac *DigitalAssetClient) CreateCollection(creator *Account, options CreateCollectionOptions) (*string, error) {


You might not need to return *string, you can probably just return string and use "" as a failure mode return type. It's standard in Go, though I'm not sure I'm attached to either.

gregnazario · 2025-06-09T02:49:16Z

digital_asset_client.go

+	descriptionBytes, err := SerializeString(options.Description)
+	if err != nil {
+		return nil, fmt.Errorf("failed to serialize description: %w", err)
+	}


It's times like this, I wish Go had throws, so it wouldn't have to be duplicated for each of these.

I would normally say, make this all into a function, so you don't duplicate the error message.

gregnazario · 2025-06-09T02:56:42Z

digital_asset_client.go

+	// Build the transaction
+	var functionName string
+	var args [][]byte
+
+	if options.IsSoulBound {


I like this breakdown

gregnazario · 2025-06-09T02:57:14Z

digital_asset_client.go

+		functionName = "mint_soul_bound"
+
+		// Serialize the soul_bound_to address
+		recipientBytes, err := bcs.Serialize(&recipient)
+		if err != nil {
+			return nil, fmt.Errorf("failed to serialize recipient address: %w", err)
+		}
+
+		// mint_soul_bound requires the recipient address as the last argument
+		args = [][]byte{
+			collectionBytes,
+			descriptionBytes,
+			nameBytes,
+			uriBytes,
+			propertyKeysBytes,
+			propertyTypesBytes,
+			propertyValuesBytes,
+			recipientBytes, // soul_bound_to: address
+		}


Would probably move pieces like this to an internal function (lowercase starting letter) e.g. mintSoulboundArgs()

gregnazario · 2025-06-09T03:04:05Z

digital_asset_client.go

+		case "address":
+			// For address, decode hex and use as 32-byte array
+			addressStr := strings.TrimPrefix(value, "0x")
+			addressBytes, parseErr := hex.DecodeString(addressStr)
+			if parseErr != nil {
+				return nil, fmt.Errorf("failed to parse address value '%s': %w", value, parseErr)
+			}
+			// Ensure it's 32 bytes
+			if len(addressBytes) < 32 {
+				padded := make([]byte, 32)
+				copy(padded[32-len(addressBytes):], addressBytes)
+				addressBytes = padded
+			}
+			valueBytes = addressBytes


No need to write a parser, there's already a parser for address

gregnazario · 2025-06-09T03:04:34Z

digital_asset_client.go

+		case "bool":
+			// For bool, parse and BCS serialize as bool
+			boolValue, parseErr := strconv.ParseBool(value)
+			if parseErr != nil {
+				return nil, fmt.Errorf("failed to parse bool value '%s': %w", value, parseErr)
+			}
+			valueBytes, err = bcs.SerializeSingle(func(s *bcs.Serializer) {
+				s.Bool(boolValue)
+			})


There actually should already be convertArg to convert all of these types already

gregnazario · 2025-06-09T03:04:56Z

digital_asset_client.go

+			// For byte vector, decode from hex or use as UTF-8, then BCS serialize
+			var bytesValue []byte
+			if strings.HasPrefix(value, "0x") {
+				bytesValue, err = hex.DecodeString(value[2:])
+				if err != nil {
+					return nil, fmt.Errorf("failed to parse hex bytes value '%s': %w", value, err)
+				}
+			} else {
+				bytesValue = []byte(value)
+			}
+			// BCS serialize the byte vector
+			valueBytes, err = bcs.SerializeSingle(func(s *bcs.Serializer) {
+				s.WriteBytes(bytesValue)
+			})
+


Similarly, I would use the existing convertArg

gregnazario · 2025-06-09T03:05:18Z

digital_asset_client.go

+		default:
+			// For unknown types, fall back to BCS string
+			fmt.Printf("Warning: unknown property type '%s', treating as Move String\n", propertyType)
+			valueBytes, err = bcs.SerializeSingle(func(s *bcs.Serializer) {
+				s.WriteString(value)
+			})
+		}


Hmm... maybe want to error out, rather than write something that might not parse

gregnazario · 2025-06-09T03:05:57Z

examples/digital_asset/main.go

+)
+
+const (
+	testEd25519PrivateKey = "ed25519-priv-0xc5338cd251c22daa8c9c9cc94f498cc8a5c7e1d2e75287a5dda91096fe64efa5"


You can also just generate new keys each time, unless you need something consistent.

gregnazario · 2025-06-16T20:06:10Z

typetag.go

+// ObjectTypeTag is the TypeTag for 0x1::object::ObjectCore
+var ObjectTypeTag = TypeTag{&StructTag{
+	Address: AccountOne,
+	Module:  "object",
+	Name:    "ObjectCore",
+}}
+


Would rename to ObjectCoreTypeTag

gregnazario · 2025-06-20T16:14:47Z

examples/digital_asset/main.go

+	// tokenAddress := // Placeholder
+
+	// transferTxHash, err := daClient.TransferToken(creator, tokenAddress, collector.AccountAddress())
+	// if err != nil {
+	// 	fmt.Printf("Warning: Failed to transfer NFT (expected without proper token address): %v\n", err)
+	// } else {
+	// 	fmt.Printf("NFT transferred with transaction hash: %s\n", *transferTxHash)
+
+	// 	// Wait for transfer
+	// 	_, err = client.WaitForTransaction(*transferTxHash)
+	// 	if err != nil {
+	// 		panic("Failed to wait for transfer:" + err.Error())
+	// 	}
+	// }


Can just remove the commented code

gregnazario · 2025-06-20T16:15:31Z

examples/digital_asset/main.go

+// main This example shows how to create and transfer digital assets (NFTs)
+func main() {
+	// Run the main example
+	example(aptos.DevnetConfig)
+}


You may have to add a test file so it runs in CI. Look at the other examples

gregnazario · 2025-06-20T16:17:22Z

digital_asset_client.go

+		var valueBytes []byte
+		var err error
+
+		switch propertyType {


You should be able to use the convertArg to convert it into the correct type for each. Then we don't need copied serialization methods

gregnazario · 2025-06-20T16:19:14Z

digital_asset_client.go

+func mintSoulboundArgs(recipient AccountAddress, collectionBytes []byte, descriptionBytes []byte, nameBytes []byte, uriBytes []byte, propertyKeysBytes []byte, propertyTypesBytes []byte, propertyValuesBytes []byte) (string, [][]byte, error) {
+	functionName := "mint_soul_bound"
+
+	// Serialize the soul_bound_to address
+	recipientBytes, err := bcs.Serialize(&recipient)
+	if err != nil {
+		return "", nil, fmt.Errorf("failed to serialize recipient: %w", err)
+	}
+
+	// mint_soul_bound requires the recipient address as the last argument
+	args := [][]byte{


I would probably take in the types, and convert them instead in the args functions, so you don't have to pass in a large list of bytes (where you might get one out of order)

gregnazario · 2025-07-01T14:41:32Z

Update changelog please

gregnazario · 2025-07-01T14:42:12Z

digital_asset_client.go

+			valueBytes, err = bcs.SerializeU8(numValue)
+
+		case "u16":
+			// For u8, parse and BCS serialize as u8


Repeated comments

gregnazario · 2025-07-01T14:42:20Z

digital_asset_client.go

+			// For u8, parse and BCS serialize as u8
+			numValue, parseErr := ConvertToU16(value)
+			if parseErr != nil {
+				return nil, fmt.Errorf("failed to parse u8 value '%s': %w", value, parseErr)


these as well

add digital asset client with create_collection and mint capabilities

7e2378e

Tlazypanda requested review from gregnazario and a team as code owners June 6, 2025 06:46

gregnazario reviewed Jun 9, 2025

View reviewed changes

use existing functions & fix lint issues

2cb0dc2

gregnazario reviewed Jun 20, 2025

View reviewed changes

gregnazario approved these changes Jul 1, 2025

View reviewed changes

Merge branch 'main' into rich_api

a0efe73

gregnazario reviewed Jul 1, 2025

View reviewed changes

add digital asset client with create_collection and mint capabilities #170

Are you sure you want to change the base?

add digital asset client with create_collection and mint capabilities #170

Uh oh!

Conversation

Tlazypanda commented Jun 6, 2025

Description

Test Plan

Related Links

Uh oh!

gregnazario left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gregnazario commented Jul 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!