Add BSGS for new field PVSS #18049

waamm · 2025-11-06T21:59:42Z

Description

Removes ThresholdConfig trait from WeightedConfig
Moves most of aptos-dkg's arkworks code from using ark_std::rand for randomness, to our (older) crate rand
Removes Fiat-Shamir entirely from das (weighted and unweighted), now it uses thread_rng() to generate random numbers.
Simplified the remaining FS code since we now no longer use it for blstrs::Scalar
Added a generate() method to existing range proof and sigma proof code, in order to make the generate() method of the new PVSS cleaner.
Removed the sample() method from GroupGenerators and replaces it with default() since we can't sample securely at the moment, and don't really seem to need it anyway.
Adds the baby-step giant-step algorithm.
Extended sigma protocol to lifted homomorphisms
Added a change_lifetime method to sigma proofs, so it can be made independent of the homomorphism
Add pp: &Self::PublicParameters to decrypt_own_share(), this reverberates through a lot of code

How Has This Been Tested?

Existing aptos-dkg tests
A new test for the baby-step giant-step algorithm.

Key Areas to Review

It's important that the new random number generation for das is secure.
aptos-core/types had to be modified due to the decrypt_own_share() change, hopefully not an issue.

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

Note

Introduces a BSGS dlog helper, switches DKG/arkworks code to rand-based RNGs with new random utilities, removes Fiat‑Shamir from DAS, adds pp to decrypt_own_share, and extends sigma/range proof infra (incl. generators), updating benches/tests/types accordingly.

Core crypto/utils:
- Add dlog/bsgs (baby-step giant-step) with table builder and tests.
- New aptos_crypto::arkworks::random utilities (UniformRand, sample_field_element[s], unsafe_random_point[s]).
- Replace ark_std::rand with rand across modules; GroupGenerators now Default() (generator-based) instead of sample().
PVSS (DAS and traits):
- Remove Fiat–Shamir from DAS verification; use thread_rng()/random scalars.
- Change Transcript::decrypt_own_share(...) signature to include pp: &Self::PublicParameters; propagate through weighted/unweighted PVSS, generic weighting, tests, benches, and types/real_dkg.
- Delete obsolete pvss/das/fiat_shamir.rs.
Sigma protocol & homomorphisms:
- Support lifted homomorphisms in fixed-base MSMs; implement Trait for LiftHomomorphism and add proper DST composition.
- Add Proof::change_lifetime and enable verification with generic hom types.
- Use rand_core bounds consistently in witnesses and proofs.
Range proofs / KZG:
- Update hiding KZG: redefine Commitment and CommitmentRandomness (alias to Scalar), adapt open/verify.
- Extend Univariate DeKART (v1, v2): switch RNG, add proof generate() helpers, minor API tweaks (commit randomness handling), FS helpers streamlined.
Benches/Tests:
- Update benches to GroupGenerators::default() and new APIs; add random proof generators.
- Adjust tests for new decrypt_own_share param and RNG changes; add BSGS test.
Misc:
- Remove ThresholdConfig impl from WeightedConfig.
- Dependency bumps (e.g., fastrand 2.3.0, proc-macro2 1.0.103).

^{Written by Cursor Bugbot for commit 013d7f1. This will update automatically on new commits. Configure here.}

cursor

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 7

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

crates/aptos-dkg/src/pvss/das/weighted_protocol.rs

crates/aptos-dkg/src/pvss/das/unweighted_protocol.rs

alinush

Let's discuss!

crates/aptos-crypto/src/arkworks/random.rs

crates/aptos-dkg/src/dlog/bsgs.rs

alinush · 2025-11-07T17:20:53Z

crates/aptos-dkg/src/sigma_protocol/homomorphism/fixed_base_msms.rs

+    H: sigma_protocol::Trait<E>,
+    LargerDomain: Witness<E>,
+{
+    fn dst(&self) -> Vec<u8> {


I think we gotta be a bit careful here. It may be easier to use hashing to ensure non-ambiguity.

Not saying what you have is wrong, but it may be harder to reason about.

In general, please also take a look at my thoughts here regarding domain separation & let's discuss a little.

I think out of those 3 things we are missing a session ID which we may want to add.

alinush · 2025-11-07T17:25:45Z

crates/aptos-dkg/src/sigma_protocol/traits.rs

        &self,
        public_statement: &Self::Codomain,
-        proof: &Proof<E, Self>,
+        proof: &Proof<E, H>, // Would like to set &Proof<E, Self>, but that ties the lifetime of H to that of Self, but we'd like it to be eg static


How come this was not a problem so far?

(Perpetually worried about how this abstraction is getting out of hand... 😨 )

How come this was not a problem so far?

It was, this stuff is largely inspired by the old PR.

alinush · 2025-11-07T17:27:25Z

crates/aptos-dkg/src/sigma_protocol/traits.rs

+{
+    /// No-op: circumvents the fact that proofs inherit the homomorphism’s lifetime. This method does nothing at runtime.
+    #[allow(non_snake_case)]
+    pub fn change_lifetime<H2>(self) -> Proof<E, H2>


I am so confused right now...

Homomorphisms often carry references to public parameters, but the Proof does not. So the lifetime of the Proof should not depend on that, but for some reason Rust doesn't think that way and ties the lifetime of Proof to its generic parameters.

A different workaround would be to make Proof generic over eg <E, H::Domain, H::Codomain> instead, but that seems uglier to me.

crates/aptos-dkg/src/fiat_shamir.rs

crates/aptos-dkg/src/pvss/weighted/weighted_config.rs

crates/aptos-dkg/src/dlog/bsgs.rs

github-actions · 2025-11-07T21:59:59Z

✅ Forge suite `compat` success on `eace41639a33cfd0e2ba783814be05cc2a8e7dbd` ==> `013d7f178b7a39878179d95403a209cfb18aaa3e`

Compatibility test results for eace41639a33cfd0e2ba783814be05cc2a8e7dbd ==> 013d7f178b7a39878179d95403a209cfb18aaa3e (PR)
1. Check liveness of validators at old version: eace41639a33cfd0e2ba783814be05cc2a8e7dbd
compatibility::simple-validator-upgrade::liveness-check : committed: 14405.07 txn/s, latency: 2381.21 ms, (p50: 2500 ms, p70: 2600, p90: 2800 ms, p99: 3700 ms), latency samples: 471860
2. Upgrading first Validator to new version: 013d7f178b7a39878179d95403a209cfb18aaa3e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5315.10 txn/s, latency: 6483.68 ms, (p50: 7200 ms, p70: 7300, p90: 7300 ms, p99: 7400 ms), latency samples: 182700
3. Upgrading rest of first batch to new version: 013d7f178b7a39878179d95403a209cfb18aaa3e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5215.52 txn/s, latency: 6632.32 ms, (p50: 7300 ms, p70: 7400, p90: 7500 ms, p99: 7600 ms), latency samples: 180360
4. upgrading second batch to new version: 013d7f178b7a39878179d95403a209cfb18aaa3e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8243.86 txn/s, latency: 4133.50 ms, (p50: 4500 ms, p70: 4500, p90: 4700 ms, p99: 4800 ms), latency samples: 275860
5. check swarm health
Compatibility test for eace41639a33cfd0e2ba783814be05cc2a8e7dbd ==> 013d7f178b7a39878179d95403a209cfb18aaa3e passed
Test Ok

github-actions · 2025-11-07T22:01:15Z

✅ Forge suite `realistic_env_max_load` success on `013d7f178b7a39878179d95403a209cfb18aaa3e`

two traffics test: inner traffic : committed: 13503.41 txn/s, submitted: 13503.47 txn/s, expired: 0.05 txn/s, latency: 2788.24 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3900 ms), latency samples: 5028340
two traffics test : committed: 100.02 txn/s, latency: 801.77 ms, (p50: 800 ms, p70: 800, p90: 900 ms, p99: 1600 ms), latency samples: 1620
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.412, avg: 2.167", "ConsensusProposalToOrdered: max: 0.166, avg: 0.164", "ConsensusOrderedToCommit: max: 0.081, avg: 0.074", "ConsensusProposalToCommit: max: 0.247, avg: 0.238"]
Max non-epoch-change gap was: 1 rounds at version 2778408 (avg 0.00) [limit 4], 1.22s no progress at version 4192948 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.29s no progress at version 2373583 (avg 0.29s) [limit 16].
Test Ok

github-actions · 2025-11-07T22:02:12Z

✅ Forge suite `framework_upgrade` success on `eace41639a33cfd0e2ba783814be05cc2a8e7dbd` ==> `013d7f178b7a39878179d95403a209cfb18aaa3e`

Compatibility test results for eace41639a33cfd0e2ba783814be05cc2a8e7dbd ==> 013d7f178b7a39878179d95403a209cfb18aaa3e (PR)
Upgrade the nodes to version: 013d7f178b7a39878179d95403a209cfb18aaa3e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2102.16 txn/s, submitted: 2107.24 txn/s, failed submission: 5.08 txn/s, expired: 5.08 txn/s, latency: 1390.42 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 190501
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2152.75 txn/s, submitted: 2160.81 txn/s, failed submission: 8.06 txn/s, expired: 8.06 txn/s, latency: 1358.34 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 192341
5. check swarm health
Compatibility test for eace41639a33cfd0e2ba783814be05cc2a8e7dbd ==> 013d7f178b7a39878179d95403a209cfb18aaa3e passed
Upgrade the remaining nodes to version: 013d7f178b7a39878179d95403a209cfb18aaa3e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2068.90 txn/s, submitted: 2076.11 txn/s, failed submission: 7.21 txn/s, expired: 7.21 txn/s, latency: 1409.38 ms, (p50: 1300 ms, p70: 1500, p90: 1800 ms, p99: 2500 ms), latency samples: 189320
Test Ok

waamm and others added 28 commits November 4, 2025 08:52

Refactored so HKZG supports sigma protocols

d18c287

Simplifications to DeKART <-> HKZG

826089d

Added SCRAPE

29af5c1

Added group test to SCRAPE

75fe552

Refactored fiat-shamir for new PVSS

df0328d

Small changes to comments

543363e

Added SCRAPE test but soundness is failing

d57fe46

Fixed bug

62fd494

Fix lint

c05769e

Fix possible bug

8a844c6

SCRAPE tests are bugged

d290af9

Added diagram, still need to fix SCRAPE tests

1d65edf

Working on debugging SCRAPE...

cfcb4fc

Small edit

589b84a

Tests passing yay

8761bc2

Final comments

a3c5284

Initial stuff

de609c0

Started replacing rand stuff...

00cb386

Ported rand stuff to the old version

014c34d

Merge branch 'main' into wicher/new-pvss-fifth-pr

5f76503

Tried a merge

b3ee25c

Small stuff

e868556

Redo FS removal

e03261d

Restore range proof bench

5a48d95

Remove ThresholdConfig trait from weighted config

eaac2b4

More generate() and removed insecure point generation

1d27295

Tiny edit

e0e254f

Added BSGS

41e5fbf

waamm changed the title ~~Removes Fiat-Shamir for das and ark_std::rand~~ Add BSGS for new field PVSS Nov 7, 2025

Add license

e254d26

Final edits

16267e0

waamm marked this pull request as ready for review November 7, 2025 16:22

waamm requested review from alinush, rex1fernando and zjma as code owners November 7, 2025 16:22

cursor bot reviewed Nov 7, 2025

View reviewed changes

crates/aptos-dkg/src/pvss/das/weighted_protocol.rs Show resolved Hide resolved

crates/aptos-dkg/src/pvss/das/unweighted_protocol.rs Show resolved Hide resolved

alinush reviewed Nov 7, 2025

View reviewed changes

rex1fernando reviewed Nov 7, 2025

View reviewed changes

crates/aptos-dkg/src/pvss/weighted/weighted_config.rs Outdated Show resolved Hide resolved

alinush approved these changes Nov 7, 2025

View reviewed changes

rex1fernando approved these changes Nov 7, 2025

View reviewed changes

Add pp: &Self::PublicParameters to decrypt_own_share()

b8a0dd0

alinush reviewed Nov 7, 2025

View reviewed changes

crates/aptos-dkg/src/dlog/bsgs.rs Outdated Show resolved Hide resolved

alinush reviewed Nov 7, 2025

View reviewed changes

crates/aptos-dkg/src/dlog/bsgs.rs Outdated Show resolved Hide resolved

Put table back and simplified FS code

2e4fc0f

waamm enabled auto-merge (squash) November 7, 2025 21:11

waamm added 2 commits November 7, 2025 22:15

Trivial edit

7cb9577

Restored pp to old version from review

013d7f1

This comment has been minimized.

Sign in to view

waamm merged commit 5aabfdb into main Nov 7, 2025
61 of 65 checks passed

waamm deleted the wicher/new-pvss-fifth-pr branch November 7, 2025 22:53

Add BSGS for new field PVSS #18049

Add BSGS for new field PVSS #18049

Conversation

waamm commented Nov 6, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

This is the final PR Bugbot will review for you during this billing cycle

Uh oh!

Uh oh!

Uh oh!

alinush left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alinush Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

alinush Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

alinush Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

alinush Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

waamm Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

alinush Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

waamm Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 7, 2025

✅ Forge suite compat success on eace41639a33cfd0e2ba783814be05cc2a8e7dbd ==> 013d7f178b7a39878179d95403a209cfb18aaa3e

Uh oh!

github-actions bot commented Nov 7, 2025

✅ Forge suite realistic_env_max_load success on 013d7f178b7a39878179d95403a209cfb18aaa3e

Uh oh!

github-actions bot commented Nov 7, 2025

✅ Forge suite framework_upgrade success on eace41639a33cfd0e2ba783814be05cc2a8e7dbd ==> 013d7f178b7a39878179d95403a209cfb18aaa3e

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

waamm commented Nov 6, 2025 •

edited by cursor bot

Loading

waamm Nov 7, 2025 •

edited

Loading

✅ Forge suite `compat` success on `eace41639a33cfd0e2ba783814be05cc2a8e7dbd` ==> `013d7f178b7a39878179d95403a209cfb18aaa3e`

✅ Forge suite `realistic_env_max_load` success on `013d7f178b7a39878179d95403a209cfb18aaa3e`

✅ Forge suite `framework_upgrade` success on `eace41639a33cfd0e2ba783814be05cc2a8e7dbd` ==> `013d7f178b7a39878179d95403a209cfb18aaa3e`