Skip to content

abort function name fix in rest api #17144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Conversation

igor-aptos
Copy link
Contributor

Description

There is one more layer of indirection , which was ignored.

I looked few levels up, and couldn't see any unit tests. will see if golden files capture it.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

let function_def = code
.function_defs
.get(*function as usize)
.ok_or_else(|| anyhow::anyhow!("could not find function at index{}", function))?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space after "at index" before "{}"

@igor-aptos
Copy link
Contributor Author

@georgemitenkov , @wrwg - I've updated the PR to add insturction info as well (seems useful), i.e. in my case it would be CastU64, telling me quite nicely what is the issue. offset will be printed as well, when there are many of the same instructions.

take a look, I'll land - and if you have thoughts/comments I can update/send another PR.

@igor-aptos igor-aptos enabled auto-merge (squash) July 24, 2025 04:14

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/abort_function_name_fix branch from 6e8dd95 to 210c154 Compare July 24, 2025 16:38

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 210c15428e3f369428995774cdd6dd337149be23

Compatibility test results for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 210c15428e3f369428995774cdd6dd337149be23 (PR)
1. Check liveness of validators at old version: 8e7acd6f8692b1bf870e8232cb95eab97ab5b270
compatibility::simple-validator-upgrade::liveness-check : committed: 8657.89 txn/s, latency: 3804.87 ms, (p50: 4000 ms, p70: 4400, p90: 4700 ms, p99: 5600 ms), latency samples: 289600
2. Upgrading first Validator to new version: 210c15428e3f369428995774cdd6dd337149be23
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2492.20 txn/s, latency: 13537.85 ms, (p50: 14900 ms, p70: 15400, p90: 15900 ms, p99: 16000 ms), latency samples: 93340
3. Upgrading rest of first batch to new version: 210c15428e3f369428995774cdd6dd337149be23
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2490.11 txn/s, latency: 13565.47 ms, (p50: 14900 ms, p70: 15500, p90: 15800 ms, p99: 16100 ms), latency samples: 92800
4. upgrading second batch to new version: 210c15428e3f369428995774cdd6dd337149be23
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4278.76 txn/s, latency: 7928.18 ms, (p50: 8800 ms, p70: 9000, p90: 9400 ms, p99: 9600 ms), latency samples: 151180
5. check swarm health
Compatibility test for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 210c15428e3f369428995774cdd6dd337149be23 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 210c15428e3f369428995774cdd6dd337149be23

two traffics test: inner traffic : committed: 11630.49 txn/s, latency: 3240.88 ms, (p50: 3000 ms, p70: 3300, p90: 3300 ms, p99: 5100 ms), latency samples: 4422180
two traffics test : committed: 99.98 txn/s, latency: 1310.71 ms, (p50: 1200 ms, p70: 1500, p90: 1900 ms, p99: 3200 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.587, avg: 2.021", "ConsensusProposalToOrdered: max: 0.166, avg: 0.163", "ConsensusOrderedToCommit: max: 0.537, avg: 0.370", "ConsensusProposalToCommit: max: 0.700, avg: 0.533"]
Max non-epoch-change gap was: 1 rounds at version 1872861 (avg 0.00) [limit 4], 2.01s no progress at version 1877039 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.62s no progress at version 1936607 (avg 0.62s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 210c15428e3f369428995774cdd6dd337149be23

Compatibility test results for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 210c15428e3f369428995774cdd6dd337149be23 (PR)
Upgrade the nodes to version: 210c15428e3f369428995774cdd6dd337149be23
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1730.34 txn/s, submitted: 1736.37 txn/s, failed submission: 6.03 txn/s, expired: 6.03 txn/s, latency: 1793.72 ms, (p50: 1800 ms, p70: 1800, p90: 2300 ms, p99: 3000 ms), latency samples: 149241
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1730.42 txn/s, submitted: 1737.73 txn/s, failed submission: 7.31 txn/s, expired: 7.31 txn/s, latency: 1715.35 ms, (p50: 1800 ms, p70: 1800, p90: 2100 ms, p99: 2700 ms), latency samples: 156161
5. check swarm health
Compatibility test for 8e7acd6f8692b1bf870e8232cb95eab97ab5b270 ==> 210c15428e3f369428995774cdd6dd337149be23 passed
Upgrade the remaining nodes to version: 210c15428e3f369428995774cdd6dd337149be23
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1666.16 txn/s, submitted: 1671.63 txn/s, failed submission: 5.48 txn/s, expired: 5.48 txn/s, latency: 1777.20 ms, (p50: 1800 ms, p70: 1800, p90: 2100 ms, p99: 3300 ms), latency samples: 152081
Test Ok

@igor-aptos igor-aptos merged commit d9d748f into main Jul 24, 2025
90 of 94 checks passed
@igor-aptos igor-aptos deleted the igor/abort_function_name_fix branch July 24, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants