-
Notifications
You must be signed in to change notification settings - Fork 3.8k
abort function name fix in rest api #17144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
api/types/src/convert.rs
Outdated
let function_def = code | ||
.function_defs | ||
.get(*function as usize) | ||
.ok_or_else(|| anyhow::anyhow!("could not find function at index{}", function))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: space after "at index" before "{}"
@georgemitenkov , @wrwg - I've updated the PR to add insturction info as well (seems useful), i.e. in my case it would be CastU64, telling me quite nicely what is the issue. offset will be printed as well, when there are many of the same instructions. take a look, I'll land - and if you have thoughts/comments I can update/send another PR. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6e8dd95
to
210c154
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
There is one more layer of indirection , which was ignored.
I looked few levels up, and couldn't see any unit tests. will see if golden files capture it.
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist