Skip to content

[Aptos Data Client] Enable v2 requests. #17126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

JoshLind
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@JoshLind JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jul 22, 2025

This comment has been minimized.

This comment has been minimized.

Base automatically changed from txn_aux_state_sync_7 to main July 22, 2025 22:02

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the txn_aux_state_sync_9 branch from 81bcc8e to 04bb58d Compare July 23, 2025 00:44

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the txn_aux_state_sync_9 branch from 04bb58d to da7e8a6 Compare July 23, 2025 17:42

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the txn_aux_state_sync_9 branch from da7e8a6 to 0d2e458 Compare July 23, 2025 18:39

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the txn_aux_state_sync_9 branch from 0d2e458 to 12c8367 Compare July 23, 2025 19:56

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the txn_aux_state_sync_9 branch from 12c8367 to fc26c42 Compare July 23, 2025 23:09

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the txn_aux_state_sync_9 branch from fc26c42 to d498018 Compare July 24, 2025 13:18

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the txn_aux_state_sync_9 branch from d498018 to c7b77f5 Compare July 24, 2025 16:01

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 0717b6e75eafda270a60b54c43a1874b74662c9c ==> c7b77f51e2218d0f919dfe4c4654f33c214fbb2e

Compatibility test results for 0717b6e75eafda270a60b54c43a1874b74662c9c ==> c7b77f51e2218d0f919dfe4c4654f33c214fbb2e (PR)
1. Check liveness of validators at old version: 0717b6e75eafda270a60b54c43a1874b74662c9c
compatibility::simple-validator-upgrade::liveness-check : committed: 6367.02 txn/s, latency: 4950.61 ms, (p50: 3700 ms, p70: 4400, p90: 12300 ms, p99: 13600 ms), latency samples: 211600
2. Upgrading first Validator to new version: c7b77f51e2218d0f919dfe4c4654f33c214fbb2e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2448.65 txn/s, latency: 13801.52 ms, (p50: 15200 ms, p70: 15800, p90: 16200 ms, p99: 16200 ms), latency samples: 92560
3. Upgrading rest of first batch to new version: c7b77f51e2218d0f919dfe4c4654f33c214fbb2e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2477.22 txn/s, latency: 13621.35 ms, (p50: 15000 ms, p70: 15500, p90: 15900 ms, p99: 16100 ms), latency samples: 93380
4. upgrading second batch to new version: c7b77f51e2218d0f919dfe4c4654f33c214fbb2e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4343.34 txn/s, latency: 7801.69 ms, (p50: 8700 ms, p70: 9000, p90: 9200 ms, p99: 9400 ms), latency samples: 153880
5. check swarm health
Compatibility test for 0717b6e75eafda270a60b54c43a1874b74662c9c ==> c7b77f51e2218d0f919dfe4c4654f33c214fbb2e passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c7b77f51e2218d0f919dfe4c4654f33c214fbb2e

two traffics test: inner traffic : committed: 11135.21 txn/s, latency: 3381.05 ms, (p50: 3300 ms, p70: 3300, p90: 3900 ms, p99: 4800 ms), latency samples: 4233920
two traffics test : committed: 100.00 txn/s, latency: 1117.70 ms, (p50: 900 ms, p70: 1000, p90: 1200 ms, p99: 7100 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.721, avg: 2.465", "ConsensusProposalToOrdered: max: 0.168, avg: 0.164", "ConsensusOrderedToCommit: max: 0.248, avg: 0.218", "ConsensusProposalToCommit: max: 0.410, avg: 0.382"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.89s no progress at version 2790190 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.39s no progress at version 4594325 (avg 0.35s) [limit 16].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant