Skip to content

refactor(workflow): enhance SSH setup and cleanup logic #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

warnyul
Copy link
Member

@warnyul warnyul commented Jan 3, 2025

  • Reorganized the workflow to improve clarity and maintainability:
    • Added a new noop.sh script for setup post-check of known hosts.
    • Moved the Setup SSH key step after Check known hosts file for better sequence.
  • Improved the check.sh script:
    • Validates the presence of expected SSH fingerprints in the known_hosts file.
  • Updated the post_action.sh script:
    • Simplified removal of the known_hosts file instead of line-by-line cleanup.
  • Adjusted post_check.sh to ensure the known_hosts file is completely removed.
  • Updated action.yml to include corrected paths and a reordering of the steps.

@warnyul warnyul self-assigned this Jan 3, 2025
@warnyul warnyul changed the title fix(scripts): correct known_hosts validation logic refactor(workflow): enhance SSH setup and cleanup logic Jan 3, 2025
@warnyul warnyul merged commit 286a349 into main Jan 3, 2025
3 checks passed
@warnyul warnyul deleted the fix-check branch January 3, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant