fix: example sdks to use correct platform #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
Jul 23, 2025
example.php
Outdated
Comment on lines
56
to
54
| $sdk = new SDK($php, new Swagger2($spec)); | ||
| $sdk = new SDK($php, new Swagger2($serverSpec)); |
There was a problem hiding this comment.
We should not pin languages to specific platforms, the generator is agnostic. PHP being a server-side SDK is an Appwrite specific concept
ChiragAgg5k
force-pushed
the
update-example-php
branch
from
137eac3 to
e71aa39
Compare
abnegate
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
use 1.7.x for now and use correct platforms.
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.