Skip to content

fix: Number validation passthrough behaviour on 0 #18001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2022
Merged

fix: Number validation passthrough behaviour on 0 #18001

merged 3 commits into from
Nov 1, 2022

Conversation

aswathkk
Copy link
Contributor

Description

Fixes the behaviour where the Number with min and max validation doesn't passthrough the value when the value is zero.

A side effect is fixed as per the comment: #17472 (comment)

Fixes #17472

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Jest

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aswathkk aswathkk added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Oct 31, 2022
@aswathkk aswathkk requested a review from sbalaji1192 October 31, 2022 13:20
@vercel
Copy link

vercel bot commented Oct 31, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 8:48AM (UTC)

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Widget Validation Issues related to widget property validation and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Oct 31, 2022
sbalaji1192
sbalaji1192 reviewed Nov 1, 2022
View reviewed changes
sbalaji1192
sbalaji1192 reviewed Nov 1, 2022
View reviewed changes
@aswathkk aswathkk requested a review from sbalaji1192 November 1, 2022 08:40
@aswathkk
Copy link
Contributor Author

aswathkk commented Nov 1, 2022

/ok-to-test sha=32a1d22

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3368889167.
Workflow: Appsmith External Integration Test Workflow.
Commit: 32a1d22.
PR: 18001.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=18001&runId=3368889167_1

@aswathkk aswathkk merged commit d15bbe0 into release Nov 1, 2022
@aswathkk aswathkk deleted the fix/17472 branch November 1, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalaji1192 sbalaji1192 sbalaji1192 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Widget Validation Issues related to widget property validation Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ValidationTypes.Number returning 'min' value (when min value validation is set) instead of the parsed value
2 participants
@aswathkk @sbalaji1192