Sync upstream #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getsentry#74) * refactor pod enhancer so all workload resource types are used * refactor enhancer to process non-pod objects * use object caching through informer indexers * refactoring enhancer code * use constant instead of string literal
* create test for findObject * add unit tests for DsnClientMapping methods * add unit tests for sentry_dsn_data
* fix fingerprinting and common enhancer call * refactor enhancers
* add unit tests for crons_monitor_data * Update crons_monitor_data.go Co-authored-by: Anton Ovchinnikov <anton@tonyo.info> --------- Co-authored-by: Anton Ovchinnikov <anton@tonyo.info>
* add tests for root owners finding * linting
* update README with new features * Update README.md Co-authored-by: Anton Ovchinnikov <anton@tonyo.info> * Update README.md Co-authored-by: Anton Ovchinnikov <anton@tonyo.info> --------- Co-authored-by: Anton Ovchinnikov <anton@tonyo.info>
* update README with new features * update test to prevent regression * linting * change README back to avoid conflict
--------- Co-authored-by: Anton Ovchinnikov <anton@tonyo.info>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…etsentry#89) Bumps google.golang.org/protobuf from 1.29.1 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Kodem Security Scan Summary
|
Kodem Security Scan Summary
|
RafikFarhad
commented
Oct 10, 2025
| // The job is not owned by a cronJob | ||
| if !ok { | ||
| owner := pod.OwnerReferences[0] | ||
| sentryEvent.Fingerprint = append(sentryEvent.Fingerprint, owner.Kind, podName) |
There was a problem hiding this comment.
@rajesh-dhakad reading the code, I don't find it is actually needed in the prod. Maybe we added this for testing independent pod while developing/testing?
There was a problem hiding this comment.
it was part of util itself - we didn't touch this.
There was a problem hiding this comment.
yeah, the diff here between this master and upstream master is showing change on this line 111
| KindCronjob string = "CronJob" | ||
| KindReplicaset string = "ReplicaSet" | ||
| KindDeployment string = "Deployment" | ||
| ) |
Refactor ownerRef Add owner_ref for each root
RafikFarhad
force-pushed
the
farhad/sync-upstream
branch
from
6287b13 to
6e82e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled the latest upstream to sync our repo with them.