-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Allow configuration of graphql execution options(maxCoercionErrors) #8062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@cristunaranjo: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 22b92a34196776437cda26ba |
|
This looks like a good improvement. It is backwards-compatible, so I'm not going to rush to get it in before releasing v5. It needs docs. |
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: a19119dfcf8786f7a57641ab URL: https://www.apollographql.com/docs/deploy-preview/a19119dfcf8786f7a57641ab |
269e284 to
6ec3ffa
Compare
|
@cristunaranjo I would like to personally apologize for the runaround commits caused by the AI Style Review 🥲 We're still working on improving this! Judging from your commits, it looks like it would benefit from going a step further and reviewing its own suggestions so that it can make just one validated suggestion in one go and prevent all those commits. Thanks for your patience! |
mabuyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the Docs side - I'll let @glasser handle the technical review
Closes #8061
This PR introduces de ability to configure the graphql execution option
maxCoercionErrorsto control how many errors we want to allow in coercion phase. Currently, it defaults to 50 on graphql.