Skip to content

apollo-compiler@1.28.0 #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

apollo-compiler@1.28.0 #968

merged 3 commits into from
Apr 24, 2025

Conversation

goto-bus-stop
Copy link
Member

Features

  • Reject @skip/@include on subscription root fields - DerekKuc SimonSapin and goto-bus-stop, pull/963

    This implements a GraphQL spec RFC, rejecting
    subscriptions in validation that can be invalid during execution.

  • New shorthand methods for mutable directive argument access - tninesling, pull/967

    Introduces new methods:

    • DirectiveList::get_all_mut
    • DirectiveList::argument_by_name_mut
    • DirectiveList::specified_argument_by_name_mut

Fixes

  • Update ariadne trait implementations - lrlna, pull/960

    ariadne@0.5.1 release changed their type signature for ariadne::Cache trait, which required an
    update to apollo-compiler's implementation of ariadne::Cache<FileId>.

    This release also had a slight change to path formatting, so if you had any snapshots in your
    tests, you can expect a change from this:

    Error: `typeFragment1` contains too much nesting
        ╭─[overflow.graphql:11:11]
    

    to this (notice the extra white space around the file path):

    Error: `typeFragment1` contains too much nesting
        ╭─[ overflow.graphql:11:11 ]
    
  • Harden stack overflow protection - goto-bus-stop, pull/966

    Closes a theoretical gap in stack overflow protection when processing long fragment chains, and
    significantly improves validation performance on documents with thousands of fragment definitions.

@goto-bus-stop goto-bus-stop requested a review from a team as a code owner April 23, 2025 07:48
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change to Derek's github handle!

Co-authored-by: Iryna Shestak <shestak.irina@gmail.com>
@goto-bus-stop goto-bus-stop enabled auto-merge (squash) April 24, 2025 07:43
@goto-bus-stop goto-bus-stop merged commit b734550 into main Apr 24, 2025
12 checks passed
@goto-bus-stop goto-bus-stop deleted the apollo-compiler@1.28.0 branch April 24, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants