Skip to content

[spec] Implement schema coordinates #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

[spec] Implement schema coordinates #6560

merged 3 commits into from
Jun 10, 2025

Conversation

martinbonnin
Copy link
Contributor

See graphql/graphql-spec#794
This is still RFC2 in the spec but the symbols are all @ApolloExperimental and v5 is pre-release anyways so I'd suggest we merge it nevertheless.

@martinbonnin martinbonnin requested a review from BoD as a code owner June 6, 2025 16:22
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jun 6, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 6733a6d92d45c9c524cb1ebf

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

* @throws IllegalArgumentException if any of the containing elements is not found or is of an unexpected type.
*/
@ApolloExperimental
fun resolveSchemaCoordinate(schema: Schema, coordinate: GQLSchemaCoordinate): ResolvedSchemaElement? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect candidate for rich errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

@martinbonnin martinbonnin merged commit 7d3d42b into main Jun 10, 2025
6 of 7 checks passed
@martinbonnin martinbonnin deleted the schema-coordinates branch June 10, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants