Skip to content

Keep main in sync with v4 #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Keep main in sync with v4 #6541

merged 1 commit into from
Jun 6, 2025

Conversation

martinbonnin
Copy link
Contributor

The cache compiler plugin is going to add them anyways

@martinbonnin martinbonnin requested a review from BoD as a code owner May 30, 2025 12:46
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented May 30, 2025 •
edited
Loading

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: e83857b320e39fadfddb557c

@martinbonnin martinbonnin force-pushed the skip-required-fields-if-compiler-plugin-is-present branch 2 times, most recently from a1ab822 to 8b5f8bf Compare May 30, 2025 13:39
BoD
BoD approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BoD
Copy link
Contributor

BoD commented Jun 2, 2025

Heads up that we probably want this one backported to v4 as well

@martinbonnin martinbonnin mentioned this pull request Jun 3, 2025
Merged
@martinbonnin martinbonnin changed the title Skip required fields if compiler plugin is present Keep main in sync with v4 Jun 5, 2025
@martinbonnin martinbonnin force-pushed the skip-required-fields-if-compiler-plugin-is-present branch from 5849532 to 5d51249 Compare June 5, 2025 08:23
@martinbonnin martinbonnin force-pushed the skip-required-fields-if-compiler-plugin-is-present branch from 5d51249 to 119bd5a Compare June 5, 2025 09:16
@martinbonnin
Copy link
Contributor Author

martinbonnin commented Jun 5, 2025 •
edited
Loading

Differences between main and 4.x:

  • main has the separated data builders
  • main has SchemaDocumentTransform
  • main removes OperationOutputGenerator and uses OperationIdsGenerator instead
  • main removes all ApolloCompilerPlugin methods except for beforeCompilationStep and operationIds
  • main does not add fragments for key fields
  • main runs document transforms after validation

@martinbonnin martinbonnin requested a review from BoD June 5, 2025 09:22
BoD
BoD approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚙️

@martinbonnin martinbonnin merged commit e461fd2 into main Jun 6, 2025
7 of 8 checks passed
@martinbonnin martinbonnin deleted the skip-required-fields-if-compiler-plugin-is-present branch June 6, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbonnin @svc-apollo-docs @BoD