[IJ Plugin] Fix pulling normalized cache for recent AS #6437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Selector which doesn't exist in certain IDE versions
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: dbcf03c702106fa049be14dd |
Comment on lines
+74
to
+76
| // Use a dummy NetworkTransport for subscriptions (which are not used), because the default one | ||
| // references CoroutineDispatcher.limitedParallelism which doesn't exist in certain IDE versions. | ||
| // (See https://plugins.jetbrains.com/docs/intellij/using-kotlin.html#coroutinesLibraries) |
There was a problem hiding this comment.
TIL. Is there a Youtrack to remove this limitation? We're able to workaround for now but it's not great moving forward.
There was a problem hiding this comment.
I didn't find one, so I opened https://youtrack.jetbrains.com/issue/IJPL-182123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6436
There were 2 issues:
CoroutineDispatcher.limitedParallelismreferenced fromWebSocketNetworkTransport, which we don't needddmlibcompatibility.toDeviceSelectorapparently no longer exists in AS, but we also don't need it