Skip to content

Java Codegen: add some @SuppressWarnings("unchecked") #6434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ internal class BuilderBuilder(
fun build(): TypeSpec {
return TypeSpec.classBuilder(JavaClassNames.Builder.simpleName())
.addModifiers(Modifier.PUBLIC, Modifier.STATIC, Modifier.FINAL)
.addAnnotation(suppressAnnotation("unchecked"))
.addFields(builderFields())
.addMethod(MethodSpec.constructorBuilder().build())
.addMethods(fieldSetterMethodSpecs())
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
package com.apollographql.apollo.compiler.codegen.java.helpers

import com.apollographql.apollo.compiler.codegen.java.JavaClassNames
import com.apollographql.apollo.compiler.codegen.java.S
import com.squareup.javapoet.AnnotationSpec

internal fun deprecatedAnnotation() = AnnotationSpec
.builder(JavaClassNames.Deprecated)
.build()

internal fun suppressDeprecatedAnnotation() = AnnotationSpec.builder(JavaClassNames.SuppressWarnings)
.addMember("value", S, "deprecation")
.build()
internal fun suppressDeprecatedAnnotation() = suppressAnnotation("deprecation")
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.apollographql.apollo.compiler.codegen.java.helpers

import com.apollographql.apollo.compiler.codegen.java.JavaClassNames
import com.apollographql.apollo.compiler.codegen.java.S
import com.squareup.javapoet.AnnotationSpec

internal fun suppressAnnotation(value: String) = AnnotationSpec.builder(JavaClassNames.SuppressWarnings)
.addMember("value", S, value)
.build()
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import com.apollographql.apollo.compiler.codegen.java.L
import com.apollographql.apollo.compiler.codegen.java.S
import com.apollographql.apollo.compiler.codegen.java.T
import com.apollographql.apollo.compiler.codegen.java.helpers.codeBlock
import com.apollographql.apollo.compiler.codegen.java.helpers.suppressAnnotation
import com.apollographql.apollo.compiler.codegen.java.helpers.toListInitializerCodeblock
import com.apollographql.apollo.compiler.ir.BVariable
import com.apollographql.apollo.compiler.ir.BooleanExpression
Expand All @@ -29,6 +30,7 @@ internal class CompiledSelectionsBuilder(
return TypeSpec.classBuilder(rootName)
.addModifiers(Modifier.PUBLIC)
.addFields(selectionSets.map { it.fieldSpec() })
.addAnnotation(suppressAnnotation("unchecked"))
.build()
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.apollographql.apollo.compiler.codegen.java.JavaClassNames
import com.apollographql.apollo.compiler.codegen.java.JavaContext
import com.apollographql.apollo.compiler.codegen.java.helpers.readFromResponseCodeBlock
import com.apollographql.apollo.compiler.codegen.java.helpers.responseNamesFieldSpec
import com.apollographql.apollo.compiler.codegen.java.helpers.suppressAnnotation
import com.apollographql.apollo.compiler.codegen.java.helpers.toClassName
import com.apollographql.apollo.compiler.codegen.java.helpers.writeToResponseCodeBlock
import com.apollographql.apollo.compiler.ir.IrModel
Expand Down Expand Up @@ -74,6 +75,7 @@ internal class MonomorphicFieldResponseAdapterBuilder(
private fun readFromResponseMethodSpec(): MethodSpec {
return MethodSpec.methodBuilder(fromJson)
.addModifiers(Modifier.PUBLIC)
.addAnnotation(suppressAnnotation("unchecked"))
.returns(adaptedClassName)
.addException(JavaClassNames.IOException)
.addParameter(JavaClassNames.JsonReader, reader)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading